Design comparison
Solution retrospective
it was lovely working on real life project
Community feedback
- @shashreesamuelPosted over 2 years ago
Hey opeyemil, good job completing this challenge. Keep up the good work
Your solution looks good however I think you should consider the following
-
your qr-code image has a bit too much padding
-
Your card title is supposed to bold and the color should be the one specified in the
style-guide.md
file. -
The font size of your card description should be bigger and the color specified should be according to the
style-guide.md
file.
In terms of your accessibility issues simply wrap all your content between
<main>
tagsIn terms of your validation error
Bad value images\image-qr-code.png for attribute src on element img: Backslash (\) used as path segment delimiter.
This is because you haveimages\image-qr-code.png
instead ofimages/image-qr-code.png
.I hope this helps
Cheers Happy coding š
0@Opeyemil-codePosted over 2 years agoIt helps, thanks bro, I'll work on that
@TheCoderGuru
0 -
- @ZakSchenckPosted over 2 years ago
Good job dude! Would you like any feedback?
0@Opeyemil-codePosted over 2 years agoYup Bro, thanks I'll really appreciate
@ZakSchenck
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord