VanillaJs

Community feedback

• 

  P

  Curtis•930

  @webguy83Posted over 2 years ago

  Yeah it's very broken on my mobile device too. Be sure to never make fixed widths and heights in pixels unless you absolutely have to. I see in your CSS you have a lot of that.

  1

  ---

  

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted over 2 years ago

  @webguy83 ok thank you for your feedback . I am correcting it.

  0

  

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted over 2 years ago

  @rameshkmunjal corrected now. Thanks.

  0
• 

  P

  Zak Schenck•40

  @ZakSchenckPosted over 2 years ago

  A quick suggestion I have is to make it so when there's 0 items selected, you can't add the item to your cart. I am able to add 0 items to cart. Also I sort of broke the site by "spam adding" items to cart. It made the cart dropdown much longer than the window height. To fix this you could maybe add overflow-y: scroll; to it. Hope these helped. Good job.

  0

  ---

  

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted over 2 years ago

  @ZakSchenck Thanks for feedback. It was useful and i have improved my solution accordingly. Hoping your valuable input in future also. Thanks again.

  0
• 

  zyusuke•140

  @zyusuke10Posted over 2 years ago

  It’s not responsive 🥲 Try checking it on your phone!

  0

  ---

  

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted over 2 years ago

  @zyusuke10 Thanks for your feedback. in challenge required screen size are 375px and 1440px . I have checked it after your comments and it is working okay. some mobiles come with more than 375px wide screen . I am going to amend it to adjust accordingly.

  0

  

  Ramesh Kumar Munjal•580

  @rameshkmunjalPosted over 2 years ago

  @zyusuke10 Corrected now . Thanks.

  0