Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

VanillaJs

@rameshkmunjal

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Community feedback

P
Curtis 890

@webguy83

Posted

Yeah it's very broken on my mobile device too. Be sure to never make fixed widths and heights in pixels unless you absolutely have to. I see in your CSS you have a lot of that.

1

@rameshkmunjal

Posted

@webguy83 ok thank you for your feedback . I am correcting it.

0

@rameshkmunjal

Posted

@rameshkmunjal corrected now. Thanks.

0
P

@ZakSchenck

Posted

A quick suggestion I have is to make it so when there's 0 items selected, you can't add the item to your cart. I am able to add 0 items to cart. Also I sort of broke the site by "spam adding" items to cart. It made the cart dropdown much longer than the window height. To fix this you could maybe add overflow-y: scroll; to it. Hope these helped. Good job.

0

@rameshkmunjal

Posted

@ZakSchenck Thanks for feedback. It was useful and i have improved my solution accordingly. Hoping your valuable input in future also. Thanks again.

0
zyusuke 140

@zyusuke10

Posted

It’s not responsive 🥲 Try checking it on your phone!

0

@rameshkmunjal

Posted

@zyusuke10 Thanks for your feedback. in challenge required screen size are 375px and 1440px . I have checked it after your comments and it is working okay. some mobiles come with more than 375px wide screen . I am going to amend it to adjust accordingly.

0

@rameshkmunjal

Posted

@zyusuke10 Corrected now . Thanks.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord