E-commerce product page challenge hub build using React

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey MohamedBehhar, good job on completing this solution keep up the good work.

  Your solution looks good on the right path however I have some suggestions

  • The product name needs some margin-top

  • The font size of the product name needs to be a bit bigger

  • The description of the product needs some line-height.

  • The price with the strikethrough needs some margin-top

  • The width of the button should be a bit smaller

  • The color of the button should be a darker orange.

  • The color of the title should be a darker orange. I recommend referring to the style-guide.md file to be sure

  • The color of the "50%" should be a darker orange.

  In terms of your accessibility issues, simply wrap all your content between <main> tags to get rid of all accessibility issues.

  In terms of your validation errors, a <p> tag is not allowed to be a child of the <button> tag.

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  1

  ---

  

  Mohamed•325

  @MohamedBehharPosted over 2 years ago

  @TheCoderGuru thanks a lot for your feedback, it's really helpful , I'll apply what you suggest, thanks again;

  0
• 

  P

  Zak Schenck•40

  @ZakSchenckPosted over 2 years ago

  @TheCoderGuru gave excellent feedback, but I'd like to also suggest adding a notification for when the cart has items in it. I would have never known it had items in it until I checked. I did this by adding a container for the cart image and notification, then setting the position of the notification to absolute and positioned it to my liking. There are more way to do it though.

  Marked as helpful

  0

  ---

  

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  ZakSchenck yes I completely agree with your suggestion of an notification icon indicator in the functionality aspect because in terms of accessibility you need to have an icon to notify visitors when they have added items to the cart although it was not a part of the design

  It would also be helpful to specifically have the notification icon indicator display the number of items in the cart because you can have the indicator being shown but there are no items in the cart so that is where some logic comes into effect.

  I hope this helps and sounds sensible

  Cheers Happy coding 👍

  Marked as helpful

  1

  

  Mohamed•325

  @MohamedBehharPosted over 2 years ago

  @ZakSchenck yes I'll, I just forget it, thanks a lot for your feedback.

  0