All comments

• 

  Jordananibe•10

  @JordananibeSubmitted 9 months ago

  Any comment is welcome

  

  my Qr code components

  2

  40
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Jordananibe

  Congratulations on completing "Qr code components" challenge . I have some advices to help you improving it , add these styles on the body: display:flex; (to use flex properties) height: 100vh; (to make sure that the body take the whole page height) align-items: centre (to center vertically ) Justify-content:center; (to center horizontally) margin is not a good way to centre your div as it fix its position so you can delete the style{ margin-left: 38%; margin-right: 50%; margin-top: 200px; } from your "container div and use better the flex properties

  0
• 

  Efeh2•90

  @Efeh2Submitted 9 months ago

  

  Responsive Page

  1

  60
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Efeh2

  Congratulations on completing this challenge . I have some advices to help you improving it , add on your "flexbox-container" div the style property (height: 100vh) that to let the div take thewhole page height so the (align-items: center) could have the vertical area that will center the div in, then delete (padding: 4rem ) as it is unneeded after adding the (height: 100vh)

  3
• 

  Durgesh3829•10

  @Durgesh3829Submitted 9 months ago

  

  QR code

  2

  40
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Durgesh3829

  Congratulations on completing "QR code" challenge . I have some advices to help you improving it , add a new div that contains the "box" div then add: display:flex; (to use flex properties) height: 100vh; (to make sure that the new div take the whole page height) align-items: centre (to center vertically ) Justify-content:center; (to center horizontally) margin-top is not the best way to centre your div as it fix its position so you can delete the style(margin-top: 100px ) from your "box" div and use better the flex properties

  0
• 

  nimishaparmar1304•50

  @nimishaparmar1304Submitted 9 months ago

  

  QR Componenet using HTML and CSS.

  1

  20
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, nimishaparmar1304

  Congratulations on completing "profile-card-component-main" challenge . I have some advices to help you improving it , add a new div that contains the "qr-component" div then add: display:flex; (to use flex properties) height: 100vh; (to make sure that the new div take the whole page height) align-items: centre (to center vertically ) Justify-content:center; (to center horizontally) margin-top is not a good way to centre your div as it fix its position so you can delete the style(margin: 100px 0px 0px 800px;) from your "qr-component" div and use better the flex properties

  0

  This comment has received 1 replyShow
• 

  Maleyka•150

  @maleyka13Submitted 9 months ago

  

  ntf card component

  1

  30
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Maleyka

  Congratulations on completing "ntf card component" challenge . I have some advices to help you improving it , add: display:flex;(to use flex properties) justify-content:center;(to center horizontally ) align-items: centre (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card, margin is not the best way to centre your div so you can delete the style(margin:100px auto) from your card div and use better the flex properties as it is more efficient on all screen sizes

  0
• 

  EdiNahui•70

  @EdiNahuiSubmitted 9 months ago

  

  Display block, border

  1

  20
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, EdiNahui

  Congratulations on completing this challenge . I have some advices to help you improving it , add: display: flex;(to use the flex properties ) justify-content: center;(to center horizontally) align-items: center; (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card, when adding justify-content:center you can delete the (margin-left:auto; , margin-right:auto;) css properties from the main tag as justify-content:center do the same task more efficiently .

  Marked as helpful

  1
• 

  Phan lê thanh trường•1,070

  @truong231298Submitted 9 months ago

  

  vite and tailwind

  1

  30
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Phan lê thanh trường

  Congratulations on completing this challenge . I have an advice that may help you improving it , add: height: 100vh;(to make sure that the body take the whole page height) on the body to center the card that to let the (place-items:centre) css property on the body works as expected.

  Marked as helpful

  1
• 

  Areej Omar Abumuhfouz•90

  @progAreejSubmitted 9 months ago

  

  profile-card-component-main

  1

  40
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello, Areej

  Congratulations on completing "profile-card-component-main" challenge . I have some advices to help you improving it , add: align-items: centre (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card, margin-top is not the best way to centre your div so you can delete the style(margin-top:100px) from your main div and use better the flex property(align-item:centre)

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  zealx2•10

  @zealx2Submitted 9 months ago

  All feedback is welcome. Thank you in advance.

  

  QR Code Component

  2

  30
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello,zealx2

  Congratulations on completing "QR Code Component" challenge . I have some advices to help you improving it , add:display: flex; instead of display: grid; (to use the flex properties ) justify-content: center;(to center horizontally) align-items: center; (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card, + there is "<" in your html code delete it if it by fault .

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  KaranKumar•90

  @karankumar-07Submitted 9 months ago

  

  Product preview card

  1

  30
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello,KaranKumar Congratulations on completing "Product preview card" challenge . I have an advice which may help you improving your project, add :display :flex; justify-content:centre; on the class "container" which will centre the card horizontally

  0
• 

  DINESH•30

  @Dinesh-36Submitted 9 months ago

  Feedbacks are Welcomed,

  

  Product Preview Card Component

  3

  40
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello,DINESH

  Congratulations on completing "Product Preview Card Component" challenge . I have some advices to help you improving it , add:display: flex; instead of display: grid; (to use the flex properties ) justify-content: center;(to center horizontally) align-items: center; (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card

  Marked as helpful

  0
• 

  Pedro Germano•140

  @pedroGermanoSubmitted 9 months ago

  

  Column Preview

  1

  30
  

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello,Pedro Germano Congratulations on finishing "Column Preview" challenge,I have a point that could help you in improving it, try adding (flex-wrap:"wrap") css property on "<section class="cards__container">" which make the cards get under each other at small screens, try also to add a media-query that when the screen becomes small to get all the cards beside each other increase the width of the div that contain the cards gradually until all the card get under each other to make sure that all of them gets under each other at the same time, not only one card gets under the others and by turn

  Marked as helpful

  1