Design comparison
Solution retrospective
All feedback is welcome. Thank you in advance.
Community feedback
- @Youssef5107Posted 9 months ago
Hello,zealx2
Congratulations on completing "QR Code Component" challenge . I have some advices to help you improving it , add:display: flex; instead of display: grid; (to use the flex properties ) justify-content: center;(to center horizontally) align-items: center; (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card, + there is "<" in your html code delete it if it by fault .
Marked as helpful0@zealx2Posted 9 months agoTHank you so much, with your help I was able to fix it. I followed your instructions, changed the display from grid to flex, add justify-center: center to the body, and align-item: center. Thank you ones again[@Youssef5107
1 - @Bishalsnghd07Posted 9 months ago
Hi @zealx2
I see your code, you used dot in the starting of your image path, correct it that's why your image is not visible, apart from that you have a lot semantic ui issues I will recommend to read this doc, it helps me a lot too, in the starting of this journey- https://www.w3schools.com/html/html5_semantic_elements.asp
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord