Product Preview Card Component

Community feedback

• 

  Sefa•190

  @sefaonderPosted 9 months ago

  Hi @Dinesh-36 your solution is really good.

  You can just use it to center the cart on the web page you can use:

  body { height:100vh; margin:0; }

  More detailed information for css values and units

  Note : I liked the use of css grid in the design :D

  Marked as helpful

  0

  ---

  

  DINESH•30

  @Dinesh-36Posted 9 months ago

  @sefaonder thank you for your feedback i changed it and it works @media(min-width:600px) {

  body { height: 100vh; margin: 0; } }

  0

  

  Cephace12•0

  @Cephace12Posted 9 months ago

  @sefaonder

  0
• 

  Olaniyi Ezekiel•7,580

  @Ezekiel225Posted 9 months ago

  Hello there 👋 @Dinesh-36.

  Good job on completing the challenge !

  Your project looks really good!

  I have a suggestion about your code that might interest you.

  There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.

  Consider adding a min-height of 100vh to the body element so as to centralize your project.

  body { 
    min-height: 100vh;
    align-items: center;
    display: flex;
    justify-content: center;
  }
  
  

  I hope this suggestion is useful for future projects.

  Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! 🚀🌟.

  Other than that, great job!

  Happy coding.

  Marked as helpful

  0
• 

  youssef•460

  @Youssef5107Posted 9 months ago

  Hello,DINESH

  Congratulations on completing "Product Preview Card Component" challenge . I have some advices to help you improving it , add:display: flex; instead of display: grid; (to use the flex properties ) justify-content: center;(to center horizontally) align-items: center; (to center vertically ) height: 100vh;(to make sure that the body take the whole page height) on the body to center the card

  Marked as helpful

  0