All comments

• 

  Yan Aung Hein•95

  @yaungheinSubmitted about 3 years ago

  It would be so appreciate if you could see my codes and make code review. I am proud of myself for implementing design part, but not for the cleanliness of code.

  

  REST Countries Solution with React, React-Redux and Styled-Components

  2

  60
  

  Yash Sharma•90

  @Yashs05Posted about 3 years ago

  Hey buddy nice job. I also implemented the skeleton part in my challange. But what I like more about your project is the recommendation of other countries from same region. It really impressed me a lot. Excellent job👏👏 BTW please check my solution if you could and please do like it if it impresses you - https://yashs05-countries-info.netlify.app.

  Hey I'm editing this comment after using your solution for some time and I have found a bug there. Whenever I search for India I get two countries - British Indian Ocean territory and India. So whenever I click on India I get to the page of British Indian Ocean territory. If I understand correctly this might be because if you are using router you would be giving India or whatever name as path so in this case I get to page of British Indian Ocean territory because it also contains term 'India' and is above of actual India. Have a look at it.

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Gassai Hamza•290

  @GHamza-DevSubmitted about 3 years ago

  Hi, this is my first project using React, Your feedback will help me a lot especially on what concern :

  • folder structure
  • Best practice
  • Code optimization

  

  TODO App using : React, localStorage API

  2

  10
  

  Yash Sharma•90

  @Yashs05Posted about 3 years ago

  You can use react-beautiful-dnd library to make drag and drop happen if you are having trouble doing in using vanilla JavaScript.

  1

  This comment has received 1 replyShow
• 

  花火•0

  @satabiSubmitted over 3 years ago

  Hi👋!

  This project took me 12 days to complete. The project is somewhat difficult but overall I learn a lot.

  Any feedback is appreciated.

  

  Sunnyside - BEM, Flex Box, Grid

  4

  30
  

  Yash Sharma•90

  @Yashs05Posted over 3 years ago

  Don't take me wrong, but you should really improve your pace. If its your first project then its good, but single pages like this should not take 12 days. Happy coding! Many more to come.

  Marked as helpful

  0
• 

  Kyle•155

  @kyle4realSubmitted over 3 years ago

  This was a blast to build. How does my CSS organization look? Is my use of media queries good?

  

  Sunnyside Agency HTML, CSS, and vanilla JavaScript

  3

  30
  

  Yash Sharma•90

  @Yashs05Posted over 3 years ago

  You have done tremendous job here in making this page. But it's a suggestion to either remove the fixed position from navbar or apply a background color to it to make it distinctive from other elements while scrolling over them. Hope my suggestion is appreciated. All the best for upcoming projects!

  1