REST Countries Solution with React, React-Redux and Styled-Components

Community feedback

• 

  Yash Sharma•90

  @Yashs05Posted about 3 years ago

  Hey buddy nice job. I also implemented the skeleton part in my challange. But what I like more about your project is the recommendation of other countries from same region. It really impressed me a lot. Excellent job👏👏 BTW please check my solution if you could and please do like it if it impresses you - https://yashs05-countries-info.netlify.app.

  Hey I'm editing this comment after using your solution for some time and I have found a bug there. Whenever I search for India I get two countries - British Indian Ocean territory and India. So whenever I click on India I get to the page of British Indian Ocean territory. If I understand correctly this might be because if you are using router you would be giving India or whatever name as path so in this case I get to page of British Indian Ocean territory because it also contains term 'India' and is above of actual India. Have a look at it.

  Marked as helpful

  0

  ---

  

  Yan Aung Hein•95

  @yaungheinPosted about 3 years ago

  @Yashs05 Uhhh, yes, it can be because those two countries have a common word in them, and the router always match the fast one. So, I think we can fix it by using alpha3Code property as the routes instead of country names.

  Btw, thanks for your time, and feedback 🥳. I will check out yours.

  0
• 

  Ch. Hassan•80

  @HSN-StudioPosted about 3 years ago

  Hi, Good evening. I'm really impressed to see your work especially that skeleton loading part is amazing. I will definitely look at your code tonight :) I'm currently implementing the mobile version of this project and I'm almost done with homepage. You can have a look at it at https://hsn-studio.github.io/countries/ Feel free to comment :)

  Regards Hassan

  0

  ---

  

  Yan Aung Hein•95

  @yaungheinPosted about 3 years ago

  @HSN-Studio Hi Hassan, Thanks for the comment, and... you did a great work so far! Keep going...

  1