Sunnyside - BEM, Flex Box, Grid

Community feedback

• 

  Yash Sharma•90

  @Yashs05Posted over 3 years ago

  Don't take me wrong, but you should really improve your pace. If its your first project then its good, but single pages like this should not take 12 days. Happy coding! Many more to come.

  Marked as helpful

  0
• 

  Ahmed Faisal•5,095

  @afrusselPosted over 3 years ago

  Hi, nice work. the hamburger menu is looking good from my side. Cool animation :). Actuaaly if you aren't a Pro user then its hard to code without having design files like figma /sketch. I just recommend one thing, while clicking on WE ARE CREATIVES down arrow it just go to next section with animation.

  Happy coding

  Marked as helpful

  0
• 

  Yuko Horita•645

  @Sloth247Posted over 3 years ago

  Hi, it looks good. However I still see the modal is kept open when I move from mobile view to desktop view. I suggest you set up conditions regarding media query in JS or convert navigation to modal in CSS on media query for mobile view.

  Marked as helpful

  0

  ---

  

  Yash Sharma•90

  @Yashs05Posted over 3 years ago

  @Sloth247 Hey! Can you tell me how to overcome this problem using conditions in Javascript. I am also facing the same problem and tried something like: if(document.getElementById('mainContainer') == "500px) { modal.style.display = "none" } else {Some code here} but it didn't work out.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Some of the issues that needs attention includes the following:

  • consider using semantic html where possible instead of divs. Elements such as header, main, footer , nav etc
  • the hamburger is supposed to interactive , hence the need to use a button - since you have used a div , you need to provide the mechanism that will enable assistive technology users to identify it as a button
  • as for headings , it is important to have only one h1 element per page , having more than one h1 element does not cause errors but is considered bad practice. Do not skip headings, they must ascend in order. Use css to control the size

  Marked as helpful

  0