Skip to content
OverviewSolutions
1
Comments
3
Dash
@WristlockDash

All comments

  • Dash•50
    @WristlockDashPosted over 1 year ago

    Hi @Fabiola971

    I would suggest a couple of things if you allow me to.

    First I think for future development it would be good practice to keep the styles in a different file or folder (styles.css), rather than the html file. As projects grow it is way more maintainable.

    The reason that the image is not showing I believe is that on line 39 and 122 you have it coded as:

    background: url(images/image-product-mobile.jpg)no-repeat;

    I would suggest to change this to two lines of code: background: url(images/image-product-mobile.jpg); background-repeat: no-repeat;

    That should fix it.

    happy coding!

    Marked as helpful
    0
  • Dash•50
    @WristlockDashPosted over 1 year ago

    Hi @Savindushehan. As a personal preference I would suggest to include hover effects on the numbers and submit button.

    I believe functionality should be the number you selected our of the total number (5). The way you coded it, you get the user to select two numbers. So when user selects only one (which is the one to rate), the message comes back that you havent defined the total of options you are selecting them from. So the reply comes with the message "You selected 5 out of undefined".

    Happy coding!

    0
  • Cesar D.•400
    @ThatDevDiazSubmitted over 1 year ago

    Here's my first challenge utilizing vanilla JS.

    Frameworks are not being utilized because i'd like to make sure I have a solid foundation of JS fundamentals. This is my first time using event handlers and calling classes from an html doc

    HTML/CSS/JS

    Readme has updated notes.

    Feedback is appreciated!

    Interactive Rating Component

    3
    Dash•50
    @WristlockDashPosted over 1 year ago

    I liked your solution. Humbly I would suggest to include transitions for the hover effect so it does not changes so abruptly. This is totally optional and more of a personal preference than anything else.

    You could test the difference on a hover with and without transition on this link: https://www.w3schools.com/css/tryit.asp?filename=trycss3_transition1

    You can test it with the transition or you can remove that line of code " transition: width 2s;" and see the difference in behaviour.

    cheers!

    Marked as helpful
    0