Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CARD COMPONENT USING "HTML5" AND "CSS3"

Fabiola971 110

@Fabiola971

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I tried to enhance the code, also display the image because in the precedent version it didn't appear.

Give me your feed-back.

Community feedback

hitmorecode 6,230

@hitmorecode

Posted

Congratulations for your effort finishing this challenge. Like mentioned above it is best practice to place the CSS in a separated file and link that file to the html.

These are the few thing that you can change.

  • Your media query breakpoint is too wide lower it to maybe 510px
  • You used position to place the card in the middle of the page, try using flexbox to do this.
  • There is no hover effect on the button
  • Add transition on the button to make the hover animation smoother

Marked as helpful

0

Fabiola971 110

@Fabiola971

Posted

@hitmorecode

Thanks for your feed-back. I'll try to improve that.

Take care.

Fabiola

0
Dash 50

@WristlockDash

Posted

Hi @Fabiola971

I would suggest a couple of things if you allow me to.

First I think for future development it would be good practice to keep the styles in a different file or folder (styles.css), rather than the html file. As projects grow it is way more maintainable.

The reason that the image is not showing I believe is that on line 39 and 122 you have it coded as:

background: url(images/image-product-mobile.jpg)no-repeat;

I would suggest to change this to two lines of code: background: url(images/image-product-mobile.jpg); background-repeat: no-repeat;

That should fix it.

happy coding!

Marked as helpful

0

Fabiola971 110

@Fabiola971

Posted

@WristlockDash

Thanks for your rapid answer. I'm going to improve my code.

Happy Coding too.

Take care!

0
Fabiola971 110

@Fabiola971

Posted

Hello!

I don't understand why my image didn't appear. Please give me a feed-back.

Sorry, for my English I'm French.

Fabiola

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord