CARD COMPONENT USING "HTML5" AND "CSS3"

Community feedback

• 

  hitmorecode•6,360

  @hitmorecodePosted over 1 year ago

  Congratulations for your effort finishing this challenge. Like mentioned above it is best practice to place the CSS in a separated file and link that file to the html.

  These are the few thing that you can change.

  • Your media query breakpoint is too wide lower it to maybe 510px
  • You used position to place the card in the middle of the page, try using flexbox to do this.
  • There is no hover effect on the button
  • Add transition on the button to make the hover animation smoother

  Marked as helpful

  0

  ---

  

  Fabiola971•110

  @Fabiola971Posted over 1 year ago

  @hitmorecode

  Thanks for your feed-back. I'll try to improve that.

  Take care.

  Fabiola

  0
• 

  Dash•50

  @WristlockDashPosted over 1 year ago

  Hi @Fabiola971

  I would suggest a couple of things if you allow me to.

  First I think for future development it would be good practice to keep the styles in a different file or folder (styles.css), rather than the html file. As projects grow it is way more maintainable.

  The reason that the image is not showing I believe is that on line 39 and 122 you have it coded as:

  background: url(images/image-product-mobile.jpg)no-repeat;

  I would suggest to change this to two lines of code: background: url(images/image-product-mobile.jpg); background-repeat: no-repeat;

  That should fix it.

  happy coding!

  Marked as helpful

  0

  ---

  

  Fabiola971•110

  @Fabiola971Posted over 1 year ago

  @WristlockDash

  Thanks for your rapid answer. I'm going to improve my code.

  Happy Coding too.

  Take care!

  0
• 

  Fabiola971•110

  @Fabiola971Posted over 1 year ago

  Hello!

  I don't understand why my image didn't appear. Please give me a feed-back.

  Sorry, for my English I'm French.

  Fabiola

  0