Design comparison
Solution retrospective
Here's my first challenge utilizing vanilla JS.
Frameworks are not being utilized because i'd like to make sure I have a solid foundation of JS fundamentals. This is my first time using event handlers and calling classes from an html doc
HTML/CSS/JS
Readme has updated notes.
Feedback is appreciated!
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0 - @itushPosted over 1 year ago
Congratulations on completing the challenge! 🎉
Welcome to the platform! 🎉 We're thrilled to have you here and excited to see your progress 💪as you continue your front-end development journey.
Your solution looks nice to me :)
-
You have used
<container class="container">
in your HTML. As per my knowledge HTML does not have a built-in <container> element. Please correct me if I'm wrong. -
You may use the transition property to beautify the hover state as suggested by @WristlockDash.
In my projects:
- I always start with mobile-first workflow.
- I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
<body> <main> All content </main> </body>
-
I Use relative units as much as possible and avoid absolute units whenever possible.
-
If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project(which you did). Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals and then move on to any framework or library.
-
I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:
📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.
📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.
I hope you find these resources helpful in your coding adventures! 🤞
I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻
Keep up the fantastic work and happy hacking! 💪✨
Marked as helpful0@ThatDevDiazPosted over 1 year ago@itush Thank you for the thorough feedback! I need to focus more on mobile work. I guess because it was only a small window I glanced over it but I could see potential future issues.
I definitely meant to make it a div and give it the class .container. I must have looked over it. I guess just because it worked I continuously overlooked it
1@itushPosted over 1 year ago@ThatDevDiaz
You are most welcome!
HTML is Fault-Tolerant and it happens to all of us, I guess :)
I'm glad to see that my feedback has been helpful for you.
BTW: It would really motivate me to provide quality support like this to the community, if you could spare a moment and give my GitHub pinned projects a ⭐️ star.
0 -
- @WristlockDashPosted over 1 year ago
I liked your solution. Humbly I would suggest to include transitions for the hover effect so it does not changes so abruptly. This is totally optional and more of a personal preference than anything else.
You could test the difference on a hover with and without transition on this link: https://www.w3schools.com/css/tryit.asp?filename=trycss3_transition1
You can test it with the transition or you can remove that line of code " transition: width 2s;" and see the difference in behaviour.
cheers!
Marked as helpful0@ThatDevDiazPosted over 1 year ago@WristlockDash You're absolutely right. I glanced over some small CSS details I could've polished up. I was super excited to get it working and responsive so I must have overlooked those small details. I'll make sure to pay attention to those small details next time regardless of how excited I am. Thanks for the feedback!
0@WristlockDashPosted over 1 year ago@ThatDevDiaz You are more than welcome! :) Glad to share.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord