Design comparison
Solution retrospective
This s my new challenge. please tell me my any problems.
Community feedback
- @WristlockDashPosted over 1 year ago
Hi @Savindushehan. As a personal preference I would suggest to include hover effects on the numbers and submit button.
I believe functionality should be the number you selected our of the total number (5). The way you coded it, you get the user to select two numbers. So when user selects only one (which is the one to rate), the message comes back that you havent defined the total of options you are selecting them from. So the reply comes with the message "You selected 5 out of undefined".
Happy coding!
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S āØļø:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img src="/images/icon-star.svg" alt="star"> š <img src="/images/icon-star.svg" alt="">
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord