Skip to content
OverviewSolutions
21
Comments
20
Vishal Maurya
@VishalMauryastp

All comments

  • Vishal Maurya•500
    @VishalMauryastpPosted 8 months ago

    Hey, you did great 👍.

    1
  • Vishal Maurya•500
    @VishalMauryastpPosted 10 months ago

    you tried well .

    Marked as helpful
    0
  • Vishal Maurya•500
    @VishalMauryastpPosted about 1 year ago

    Hi, Could you please make it mobile responsive?

    Well desktop view is fine, nice work.

    Marked as helpful
    0
  • Vishal Maurya•500
    @VishalMauryastpPosted about 1 year ago

    you tried well but there is some issue in responsiveness and fix the mobile nav height h-screen don't toggle height

    0
  • Guga•340
    @Guga-KobakhidzeSubmitted about 1 year ago

    I have successfully completed this project, and it has been an incredibly enriching experience.

    I hope that you will find it impressive, and I would greatly appreciate your valuable feedback.

    Thanks.

    Easybank landing page

    1
    Vishal Maurya•500
    @VishalMauryastpPosted about 1 year ago

    it's really impressive good job

    Marked as helpful
    0
  • wafash08•130
    @wafash08Submitted about 1 year ago

    I enjoy doing this challenge but I'm having trouble implementing responsive images in the intro section and therefore I'm wondering if I'm doing the right thing in that section. Any advice on what can be done is greatly appreciated. Thank you✌️!

    Mobile first using tailwind, reactjs, and typescript

    1
    Vishal Maurya•500
    @VishalMauryastpPosted about 1 year ago

    well done ,your are doing well

    1
  • Nathan Lowe•450
    @NathLoweSubmitted over 1 year ago

    This is actually the first design of a 1 day 1 website challenge. Please consider connecting with me on LinkedIn to follow up the whole journey. If there's something wrong or not good enough please let me know.

    Results Summary Component using HTML and CSS

    2
    Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    your code is good ,but use Json file which is comes with resources to make this design you can also take a look on my solution: click here

    0
  • Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    Hello , your code is great & responsive, I'll give you some suggestion which is given below

    
    <div class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
      Coded by <a href="#">Your Name Here</a>.
    </div>
    • write this code into footer👆 like this👇
        <footer class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
      Coded by <a href="#">Your Name Here</a>.
    </footer>

    And other things are ok . I hope ,I'm helpful😐

    0
  • Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    Hello👋. Your code is very good but I'll suggest you to write this 👇 code into footer

     <div class= "attribution">
      <small>
        Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a> </br>
        Coded by <a href="https://github.com/amansgz">@amansgz</a>
      </small>
    </div>

    -So make this <div class= "attribution"> to footer👇

     <footer class= "attribution">
      <small>
        Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a> </br>
        Coded by <a href="https://github.com/amansgz">@amansgz</a>
      </small>
    </footer>

    I hope ,I'm helpful 😐

    Marked as helpful
    0
  • Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    Hello 👋,you tried well ,but I'll suggest you how to center a container or <div>.

    • First of all use max-width: __ ; of container or <div> which you want to center.
    • Then Use these css properties into the PARENT <div> ,In your case parent is body.
    body{
           display:flex; 
            justify-content:center;
            align-item:center;
            min-height:100vh;
}

    then It will help you center the qrcode .

    I hope ,It will helpful for you😐

    Marked as helpful
    1
  • Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    Hello 👋,Your code is great, but I'll suggest you that set the padding of whole <div> in which text is written , And set margin-top property for creating the gap between tag.

    I hope ,It's Helpful😐.

    Marked as helpful
    0
  • Vishal Maurya•500
    @VishalMauryastpPosted over 1 year ago

    Hello👋 ,Everything is ok, but use the max-width:375px; of the main container which helps to make it responsive.

    Use this properties to make  the main container  **center**

.first-container{
        display:flex;
        justify-content:center;
       align-item:center;
       min-height:100vh;
}

    Hope,I'm helpful😐

    0