Product preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of min-height: 90vh. Setting the min-height: 90vh may result in the component being cut off on smaller screens.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Cel Formentera•190

  @hercel08Posted over 1 year ago

  @0xAbdulKhalid

  thanks, I'll build better next time.

  0
• 

  Vishal Maurya•500

  @VishalMauryastpPosted over 1 year ago

  Hello 👋,Your code is great, but I'll suggest you that set the padding of whole <div> in which text is written , And set margin-top property for creating the gap between tag.

  I hope ,It's Helpful😐.

  Marked as helpful

  0

  ---

  

  Cel Formentera•190

  @hercel08Posted over 1 year ago

  @VishalMauryastp thanks, I'll try that for my next challenges.

  1
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Hello Your code is great, but I'll suggest you that use flexbox for making container center its not exactly in center so just fixed it

  I hope ,It's Helpful😐.

  0