Responsive landing page with vite, react and tailwind css

Community feedback

• 

  Petrit Nuredini•2,860

  @petritnurediniPosted 10 months ago

  Great job on completing your Easybank landing page project! It's a significant step in your journey as a developer. Here are a few suggestions to enhance your code:

  1. Refactoring for Reusability and Efficiency:

     • Consider creating a reusable component for buttons. You have Button imported in several files. Make sure it's a generic component that can handle different texts, styles, and actions. This approach reduces code repetition and increases maintainability. Explore more about React component design patterns here.

  2. Accessibility Considerations:

     • Ensure all interactive elements, like buttons and links, have appropriate ARIA attributes for better accessibility. For example, adding role="button" to elements styled as buttons but not using the <button> tag. Learn more about accessibility in React here.

  3. Optimize Image Loading:

     • Use modern image formats like WebP for better performance. Also, consider implementing lazy loading for images. This can significantly improve your site's loading time, especially if there are many large images. You can learn more about image optimization here.

  Keep up the hard work! Remember, each project is a learning opportunity. Continue experimenting and exploring new ideas. Your progress is commendable, and I look forward to seeing more of your projects in the future! 🚀💻

  Marked as helpful

  1

  ---

  

  Raza Abbas•790

  @RazaAbbas62Posted 10 months ago

  Thanks for the time to review my code and write down suggestions. I will keep them in mind for future projects.@petritnuredini

  0
• 

  Theunis•210

  @theYuunPosted 10 months ago

  Very cool! I wanted to point out the missing image behind the top image you have there, but you mentioned that to Vishal. Loading images from outside sources can be a prickly subject, no doubt.

  Marked as helpful

  0
• 

  Vishal Maurya•500

  @VishalMauryastpPosted 10 months ago

  you tried well .

  Marked as helpful

  0

  ---

  

  Raza Abbas•790

  @RazaAbbas62Posted 10 months ago

  @VishalMauryastp Thanks Vishal

  0

  

  Vishal Maurya•500

  @VishalMauryastpPosted 10 months ago

  @FazeenIjaz you can also my solution click here

  Marked as helpful

  1

  

  Raza Abbas•790

  @RazaAbbas62Posted 10 months ago

  @VishalMauryastp That's looks nice. I had also added a background image in the intro section but is not being displayed due to some issue with fetching it from Git Hub.

  But one thing is that you should also add a hover effect on buttons and links, that's just a suggestion, overall it looks good. and is fully responsive .

  Enjoy Coding :)

  0

  

  Vishal Maurya•500

  @VishalMauryastpPosted 2 months ago

  @RazaAbbas62 thanks for you suggestions

  0