CSS QR code component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has been centered properly. But the issue is the content inside the body causes overflow on smaller screens and let people scroll the content, this issue want to be cleared.

  ---

  • This is just caused by over usage of padding property, we can use padding if necessary but in this project there's no need to use it

  ---

  • Now remove padding from the body in css, after setting you can able to see the changes

  body {
     padding: 4rem 1rem;
  }
  

  ---

  ---

  • Now the overflow of content has been cleared

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Aman•410

  @amansgzPosted over 1 year ago

  👋 Hello @0xAbdulKhalid

  Hope you're well. I've applied your recommendation and the overflow of content has been cleared. I'll keep working on that. Thank you for your comments 😊

  0
• 

  Vishal Maurya•500

  @VishalMauryastpPosted over 1 year ago

  Hello👋. Your code is very good but I'll suggest you to write this 👇 code into footer

   <div class= "attribution">
        <small>
          Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a> </br>
          Coded by <a href="https://github.com/amansgz">@amansgz</a>
        </small>
      </div>
  

  -So make this <div class= "attribution"> to footer👇

   <footer class= "attribution">
        <small>
          Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a> </br>
          Coded by <a href="https://github.com/amansgz">@amansgz</a>
        </small>
      </footer>
  

  I hope ,I'm helpful 😐

  Marked as helpful

  0

  ---

  

  Aman•410

  @amansgzPosted over 1 year ago

  👋 Hello @VishalMauryastp

  Hope you're well. I've already applied your suggestions.

  Thank you so much for your comments. 😊

  1