Latest solutions
Latest comments
- @JoelHernEspSubmitted over 1 year ago@Tux3er-IsmaPosted over 1 year ago
Hi Joel
Tux3er has reviewed your code 🐧
Congrats 🎉, it looks nice, but I will give you some tips for your next project 💡:
HTML 🟠:
- Your HTML is fantastic!!! Contiue like that!!!
CSS 🔵:
-
You can use CSS Grid or CSS Flexbox to center elements. I recommend you CSS Flexbox but both of them are useful too.
-
Also you can put a specific height to the page with px or better with vh
That's all, have a nice coding ⌨️!!!!
Marked as helpful1 - @Renan-do-valeSubmitted over 1 year ago@Tux3er-IsmaPosted over 1 year ago
Hi Renan
Tux3er has reviewed your code 🐧
Congrats 🎉, it looks nice, but I will give you some tips for your next project 💡:
HTML 🦴:
-
In my opinion is not a good practice to add onclick in each element. You can do it with JS with the addEventListener()
-
Also you can put tabindex instead to use it after in css with :focus
CSS 🎨:
-
As I said before you can use :focus in the numbers. Is like click in JS
-
You can also add a transition to all the hover states
JS 🟡:
-
The function mark you can get it with only HTML and CSS (as I said before)
-
You have to put a return button to return to the homepage
That's all, have a nice coding ⌨️!!!!
Marked as helpful1 -
- @chiragglallwaniSubmitted about 2 years ago@Tux3er-IsmaPosted about 2 years ago
Hi Chirag
I am Tux3er a frontend developer 🐧 and I have reviewed your code!!!
It looks nice but I will give you some advice for your next project 💡
-
You're right, it it difficult to get the exact width and height but you can do this by having a design file. Frontend Mentor gives a design file randomly every week.
-
I reccomend you to quit the overflow in your page, like this:
body{ overflow: hidden; }
-
It isn't necessary but I recomend you to put a css reset. I think the best is normalize.css 🎨
That's all, I hope this comment will help you in your next challenge 👍🏻🌟
Happy Coding Chirag ⌨️🌟
0 -
- @yousef-s2Submitted about 2 years ago@Tux3er-IsmaPosted about 2 years ago
Hi Youssef !!!
Congrats, your code looks nice 👍🏻!!!
But I will give you some tips to improve your coding skills in your next project 💡
-
In the attributes section put the link of your frontend mentor profile in the href attribute.
<a href="https://www.frontendmentor.io/profile/yousef-s2" target="_blank">Coded by Youssef</a>
-
It isn't necessary but I recomend you to put some
transition
in your css hover effects. You can put transition when you are doing hover in the add to cart button. -
Try to put some
margin-top
to your img in the responsive design using media-queries
That's all, and I hope this comment will be helpful in your future projects!!!
Happy Coding Youness 🖥️⌨️🌟
Marked as helpful0 -
- @PalHamzaSubmitted about 2 years ago@Tux3er-IsmaPosted about 2 years ago
Hi PalHamza!!!
Congrats for completing this challenge and also for your cool code 👍🏻🎉
*I have reviewed your code and I will give you some tips for your next project 💡:
-
Put an icon in the html head. There is an example
<link rel="icon" href="frontendmentor.jpg">
-
I recomend you to put a css reset in your css file. I recomend you this css reset, normalize.css 🎨
-
In css you can put variables! It isn't obligatory but css with variables is awesome. There is some documentation 📖 and some practice.
-
In your img container, inside put an img. Like this:
<img src="image.jpg" alt="Perfume">
-
Put some hover effects in your btn (button). You can get this by putting
:hover
in the button selector -
I recomend you to put BEM css in your code. This will make your css code easily to read. There is a video 📹 explaining BEM
-
Also put some media-queries in your css code. Video 📹
I hope this tips will be helpful to you in the future!!! 👍🏻😉
Happy Coding PalHamza ⌨️🖐🏻
0 -
- @LucasdeAndresSubmitted about 2 years ago@Tux3er-IsmaPosted about 2 years ago
Hi Lucas!!!
Congrats completing this challenge, and also for your awseome code 😉🎉!!!
I will give you some tips for your next project 💡:
-
In your .gitignore file I recomendyou to put the .vscode folder
-
To get a better semantic, you should replace the
<div></div>
element for a<main></main>
tag -
Try to use a css reset, I recomend you the normalize.css 🎨
-
Also I recomend you to put variables in css. You can put it in
:root{}
in css. There is some documentation if you want to practice css variables. Documentation 📖 -
Also create a custom Readme.md file. In this file you can put the tecnologies you used to build this project.
That's all. I hope this comment will be helpful for you in the future 😉👍🏻
Happy coding ⌨️🖐🏻 Lucas !!!
Marked as helpful2 -