Design comparison
Community feedback
- @Tux3er-IsmaPosted over 1 year ago
Hi Renan
Tux3er has reviewed your code π§
Congrats π, it looks nice, but I will give you some tips for your next project π‘:
HTML π¦΄:
-
In my opinion is not a good practice to add onclick in each element. You can do it with JS with the addEventListener()
-
Also you can put tabindex instead to use it after in css with :focus
CSS π¨:
-
As I said before you can use :focus in the numbers. Is like click in JS
-
You can also add a transition to all the hover states
JS π‘:
-
The function mark you can get it with only HTML and CSS (as I said before)
-
You have to put a return button to return to the homepage
That's all, have a nice coding β¨οΈ!!!!
Marked as helpful1@Renan-do-valePosted over 1 year ago@Tux3er-Isma Thanks for the advices. Initially, my goal was to use the addEventListener(), but I couldn't make it work, so I had to come up with a workaround to make it work.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord