@blurrypxlSubmitted over 3 years ago
Hello guys, I just completed this challenge. If you have any suggestions, I would really appreciate it. Thank youu
ToNisamBioJa
@ToNisamBioJaAll comments
- @ToNisamBioJaPosted over 3 years ago
Good job on this one.
It is responsive and looks like the original design.
One thing I would suggest is that you use more class names. It isnt good practice to nest elements in css this much (for example: main header h1 span ). Try to look into some naming conventions to make the code a little tidier.
Overall great job. Keep it up and happy codding!
Marked as helpful0 - @Anwar11234Submitted over 3 years ago
any feedback would be great
@ToNisamBioJaPosted over 3 years agoNice job.The site is responsive and looks good!
Only thing is that your cards stretch a little bit too much on desktop. You can just change the max width on the container from 80% to 75/70% and it should look fine then.
Also your text isnt centered on mobile view but thats about it!
Keep up the good work and happy codding!
0 - @Alex-AR-LRSubmitted over 3 years ago
I would like to know if you think I use good practices or what should change but any comment is welcome!
@ToNisamBioJaPosted over 3 years agoReally good job here!
The site looks really good on desktop and mobile.
Only thing I could recommend is that you put a max-width on your cards so they dont stretch on tablet sizes. Also try to make more media queries for different screen sizes, do some research on that.
Keep up the good work and happy codding!
Marked as helpful0 - @FelixCriolloSubmitted over 3 years ago
any advice on my code spaghetti is welcome
@ToNisamBioJaPosted over 3 years agoThe page is responsive and look like the original design.
Keep using comments in your css it makes it more readable.
Great job here. Keep it up and happy codding!
Marked as helpful0 - @CelestialVirtuosoSubmitted over 3 years ago
Any feedback is appreciated :)
@ToNisamBioJaPosted over 3 years agoGreat job!
Just add a box shadow on the card and thats it.
Keep up the good work and happy codding!
1 - @devmoisesSubmitted over 3 years ago
This challenge is very interesting, it has its details to consider, I really liked it. I await your advice and recommendations. Thanks.
@ToNisamBioJaPosted over 3 years agoHello!
Really good job on this one. You got it really close to the original design and added a nice hover animation.
The only thing you could change is the border radius but thats about it.
Keep it up! Happy codding!
Marked as helpful0 - @DavidMaillardSubmitted over 3 years ago
I tried to do an adaptative module. I don't know if I did the right choice but it looks right to me. For the responsive of the image, it may look a little weird but I chose to keep the focal point on the smiling woman.
I am open for other points of view :)
@ToNisamBioJaPosted over 3 years agoGreat work here!
It is responsive and looks great everywhere.
Keep it up and happy codding!
0 - @VladimirBrscicSubmitted over 3 years ago
Hello, i would like to now if my html semantics are correct. Thanks!
@ToNisamBioJaPosted over 3 years agoGreat job here!
Your html semantics are great.
Keep it up and happy codding!
0 - @cjain2077Submitted over 3 years ago
This is my first time uploading a solution on Frontend Mentor. Are there any improvements that can i make in this column
@ToNisamBioJaPosted over 3 years agoCongratulations on your first Frontend Mentor solution!
You have done great. The site is responsive and very close to the original design.
The only thing that you could add is a bigger line height to the text.
Keep it up and happy codding!
Marked as helpful0 - @benjoquilarioSubmitted over 3 years ago
Hello, this is my 7th challenge and first time using grid layout this challenge is so fun and it takes 3 hours for me to complete this challenge.
Feel free to drop your suggestion or feedback. ^^
@ToNisamBioJaPosted over 3 years agoYou have done great work here!
The only thing is that you forgot to put a border radius. But that is minor.
Good job on this one. Keep it up and happy codding!
0 - @JALCH-1512Submitted over 3 years ago
I'm improving my clean code with css :) some feedback would be wonderful :)
@ToNisamBioJaPosted over 3 years agoGreat work!
One thing I would suggest is that you move back your media query to 900px because the card stretches too much above 900px, especially the button. Also you forgot to change the border radius in the media query-on the sedans card(bottom left and top right) and the luxury card(bottom left and top right).
But all around great job here. Keep it up and happy codding!
0 - @karbowskamSubmitted over 3 years ago
I'm on fire! (I think? :D) But seriously - I hope the effect is quite good :)
@ToNisamBioJaPosted over 3 years agoYou indeed are on fire!
One small thing is that you forgot to put border radius on your boxes.
Good work here. Keep it up and happy codding!
Marked as helpful0
