@jordan-naSubmitted about 3 years ago
How was my approach to solving this challenge? Is the final result a good representation of the design file?
Talha
@TalhaAmjad0034All comments
- @leaninghowtousegitSubmitted over 3 years ago
Any feedback is welcome :)
- @Skyz03Submitted over 3 years ago
Hello 👋, This is my second JS challenge, I finally completed the challenge but I do I an issue and need some valuable feedback which is whenever the input value is
backspacedthe form size seem to grow and I could not find the real cause behind it. Also for the ````error-imgandborderispseudo:classa better option ortoggle``` in JS. Thank you for your valuable feedback.@TalhaAmjad0034Posted over 3 years agoYou should add padding to main section so that interactivity don't effect the outer area. Don't let it grow on its own add some margin and padding to outer the main section. 😀
Stop user to add bunch of blanck spaces to verify that name field and include 6 or 8 characters for password validity. 🙂
Good Work! Keep coding!! 💝
1 - @tttinhSubmitted over 3 years ago
Hi everyone,
Hope you have a good day. I'd like to hear feedback from you for this solution.
Thanks.
- @madegilangadityaSubmitted over 3 years ago
I have finished my first landing page challenge. Every feedback will be very appreciate, especially for code optimization. Thanks
@TalhaAmjad0034Posted over 3 years agoDamn looks perfect to me!! Change icon to hamburger menu to cross or close on click... Keep going!! Great work
0 - @GiorgiPasieshviliSubmitted over 3 years ago
would appreciate any feedback
@TalhaAmjad0034Posted over 3 years agoNice Effort, You need to make your font size responsive cause on mobile screen that gigantic text look ugly, and same goes for the images, images are not adpting to the width of screen they are like over flowing... Also add transition on buttons and those drop down menu. Overall I appreciate you on coding this!!
Marked as helpful0 - @mcornaleSubmitted over 3 years ago
Hi everybody!
This is my first challenge using BEM, SASS, Web Animations API and Parcel.
I would really appreciate if you review my code. 🐙
@TalhaAmjad0034Posted over 3 years agoI like the use of Scss in Media queries, and that black animation slider. You did a lot on that amazing slider. But after closing navbar in mobile version it shows some horizontal lines, I've seen your code, But I'm not sure where those are coming from, maybe it can be my browser issue. but in the end I give you 5 star you did a great job.
0 - @TalhaAmjad0034Submitted over 3 years ago
It is my first upload in Frontend Mentor, I've learned a lot from this project,
I have a question how can i all lazy opening of nav menu in mobile version, i struggled a lot but in vain.
Thanks for having a look and giving me any feedback/criticism so I can improve :)
@TalhaAmjad0034Posted over 3 years agoThank you soo much for your feedback, I will not repeat these mistakes from now on. ✨
0 - @rosxnbSubmitted over 3 years ago
If you have noticed something about my design and would change it yourself, please let me know. Any suggestion is welcomed by me as this my learning journey and my first solution to any challenge here at frontend mentor.
- @Dike-CodeSubmitted over 3 years ago
Hi Everyone!! What do you think of my first "FrontendMentor Challenge? Please do well to put down your opinions and suggestions of it... so for me to know what works better and what doesn't.
