Skip to content
OverviewSolutions
13
Comments
2

Sam Hemingway

@SamHemingwayCanada180 points

Caveman salesperson who has worked in enough start-ups to think "wow, the engineers are cool. I should at least try to learn a bit of this"...

Latest solutions

View more solutions

Latest comments

  • Sam Hemingway•180
    @SamHemingwayPosted almost 2 years ago

    Great implementation Juan!

    I really like the use of determining state from the URL (something I've been wanting to learn for a while now, any good tutorials you can recommend?).

    I really appreciate that you put in the work to add things like aria-label for unsighted users.

    I tested out your font selection drop down menu for keyboard accessibility, and at first glance it works great — kudos for the work you must have put in to trap keyboard focus, and that the selected font option is focused by default.

    The only weird behaviour is the fact that the page moves as we use the up/down arrow keys to select an option - perhaps there's a way to disable that default behaviour of those keys when the dropdown is active?

    Generally speaking, for things like the dropdown, I tend to turn to unstyled libraries like Radix UI as they're always bulletproof for annoying little things like this :)

    Last UX point: the only way to submit the form is by pressing enter, which might not be immediately obvious for anyone using it for the first time. A lot of users might expect a submit/search button that sends the form - I discovered this when I asked my partner to test my solution, and watched as she got confused after entering text on what to do next!

    Keep up the great work buddy!

    Marked as helpful
    0
  • Sam Hemingway•180
    @SamHemingwayPosted almost 3 years ago

    I love how well maintained and commented your CSS is Marc, great stuff!

    One thing I noticed: the teal overlay on the image appears to actually become visible on click as opposed to on hover.

    It took more time than I expected to figure out how to make this work when I started this challenge. In the end, I went with using :before and :after pseudo-classes to pull it off rather than putting the "Eye" image into the DOM itself.

    Check out the useful resources from my readme if you'd like to try figuring out how to do this yourself. And then, if you're struggling, you can see how I implemented it in my code.

    Keep up the great work!

    1