Skip to content
OverviewSolutions
11
Comments
8
Aniket
@NinjaAniket

All comments

  • Briuwu•750
    @BriuwuSubmitted almost 3 years ago

    Hello~! (●ˇ∀ˇ●)

    This project further helps me understand about JS and forms, which is really awesome! But JS still confuses me, so if you have any tips please let me know!

    Please do check this one out! If you have any feedback or suggestions, please do let me know! Thank you so much.

    Responsive Intro Component with Signup Form

    4
    Aniket•170
    @NinjaAniketPosted almost 3 years ago

    good job @Briuwu keep up the good the work! :)

    2
  • Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Hi I have gone through your code. It seems you have not wrote media queries for responsiveness. You have to include media queries to make it responsive.

    1
  • Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Got it thanks.

    0
  • Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Cool thanks Rohit.

    0
  • Lucas TAMAYA•80
    @LucasTamayaSubmitted almost 3 years ago

    Hello, I would like a global opinion on my realization.

    I have a problem with the "Number of people" input, when I reset the form, it does not update when I enter a new number.

    If you have any suggestions for improvement, don't hesitate.

    Thank you in advance for your feedback!

    Tip Calculator with React JS

    1
    Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Hi, That's because on reset your setting the value of nbPeople to 0; And you have a condition if value of nbPeople is 0 then throw the validation error.

    Marked as helpful
    0
  • Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Hi, good job just few points

    1. Missing horizontal line before "creation of jules" section
    2. In terms of code. Try to Avoid inline styles. It effects the performance. Since its a small app its ok But when app size grow inline styles are not recommender 3.In components folder try to keep those component which are reusable.

    Overall good work keep it up.

    2
  • Briuwu•750
    @BriuwuSubmitted almost 3 years ago

    Hello~! (≧∇≦)ﾉ

    For this project, I'm still adjusting on using JavaScript and CSS animation, but so far I think I'm improving little by little! But I know that it's still not enough so I will do my best!

    If you have any feedback or suggestions, please do let me know! Thank you so much.

    Responsive Article Preview Component

    3
    Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Hi , 1.Background color on the card in the design is white but in your design it seems to be light blue 2.Image seems to be too big when compated to the design 3.Also the margin between user name(michelle) and top sections seems to be too big.

    overall good job!

    1
  • Aniket•170
    @NinjaAniketPosted almost 3 years ago

    Please consider below feedbacks

    1. Hover states is missing
    2. Text should be cancel order below procced to payment button
    Marked as helpful
    0