All comments

• 

  Marlon Almeida Mousquer• 50

  @marlon101tkm

  Submitted almost 2 years ago

  

  Product Preview with pure HTML and CSS

  1

  40

  

  Maximiliano Torres• 120

  @MaxiTRR

  Posted almost 2 years ago

  Hi! Great job on this challenge! One piece of advice I can give you with your CSS code is in the media query part. You don't need to copy all the code again as it is, but you just have to select the element you want to modify and only use the properties you need to change (for example, the padding, the margin, the type of flex direction, the property of hidden, etc., but if there is code that stays the same, it is not necessary to rewrite it). This will make your code more simple, shorter and readable!

  Happy Coding!

  Marked as helpful

  0
• 

  Evelyn Matos• 80

  @evelyn-matos

  Submitted almost 2 years ago

  

  Card QR-code com HTML E CSS básico

  2

  60

  

  Maximiliano Torres• 120

  @MaxiTRR

  Posted almost 2 years ago

  Hi! Grat job in this one! I think the code is really good! Particularly, i dont like to use de HTML tags of selectors in CSS, but it really makes the code simpler and shorter, although the best practice is to use class in case in the future you decide to expand he code with more components!

  The only thing i could say of the code is, in the body selector in the CSS, the property width:100% It doesn't seem to affect the result at all, so you could have it in mind in future codings!

  Happy coding!

  0

  This comment has received 1 replyShow
• 

  Exileurt• 100

  @Exileurt

  Submitted almost 2 years ago

  I m not sure if it's working on phone, i have try with modzilla adaptative view, that ok, but on my phone, nothing..

  

  CSS and HTLM

  3

  50

  

  Maximiliano Torres• 120

  @MaxiTRR

  Posted almost 2 years ago

  Hi @Exileurt! Congratulations for this challenge! I have a tipo for you: try to place this in your body css:

  body {
    display:flex;
  justify-content:center;
  align-items:center;
  flex-direction:column;
  }
  

  This will center the whole card to the center of the screen, so yo dont have to use any margins of any kind to do it.

  Marked as helpful

  0
• 

  Bambijow• 10

  @Bambijow

  Submitted almost 2 years ago

  Hello,

  I'm pretty new to frontend development since I'm initially a backend developer, so if you have any advice about my code, feel free to send constructive feedback. Here a question I ask myself :

  • Is there any easiest way to build this component ? Because I feel like I've wrote a lot of unnecessary code.

  

  QR Code Component

  3

  60

  

  Maximiliano Torres• 120

  @MaxiTRR

  Posted almost 2 years ago

  Hi! Very good! I can suggest you, if you want to center the components for this types of challenges, to use

  body {
    display:flex;
    justify-content:center;
    align-items:center;
  }
  

  This will center your whole component without using margins of any kind, making more easy the responsiveness. (it is not a good practice doing this in a more complex project from waht i have understand, but it works fine whith this cahllenges)

  Marked as helpful

  0
• 

  Roxanne• 260

  @rox-stahl

  Submitted almost 2 years ago

  Although there isn't much to this component, I checked for ARIA labels and I hope that I didn't miss anything.

  

  QR Code Component

  1

  50

  

  Maximiliano Torres• 120

  @MaxiTRR

  Posted almost 2 years ago

  Hi! It look very good! Checking your code i recommend you to use:

  body {
    display:flex;
    justify-content:center;
    align-items:center
  }
  

  This will center the container to the center, without using any margin to place them, so yo can not worry if you modify or added more divs or containers in the future. However, i think it is not a good practice apply a display propertie in the body, but for this challenges of one component only it makes the trick!

  Marked as helpful

  0