Card QR-code com HTML E CSS básico

Community feedback

• 

  Maximiliano Torres•120

  @MaxiTRRPosted about 2 years ago

  Hi! Grat job in this one! I think the code is really good! Particularly, i dont like to use de HTML tags of selectors in CSS, but it really makes the code simpler and shorter, although the best practice is to use class in case in the future you decide to expand he code with more components!

  The only thing i could say of the code is, in the body selector in the CSS, the property width:100% It doesn't seem to affect the result at all, so you could have it in mind in future codings!

  Happy coding!

  0

  ---

  

  Evelyn Matos•80

  @evelyn-matosPosted about 2 years ago

  @MaxiTRR Obrigada... vou aplicar suas dicas :)

  0
• 

  Renato Lacerda•160

  @ralacerdaPosted about 2 years ago

  Hey, that's is a great start!

  One thing that is easy to miss is the card shadows, I also didn't notice it when I first did this challenge, so don't worry about it.

  Sometimes is hard to understand the accessibility warnings. In your solution, you are missing the "main" landmark, you can easily fix this by using the <main> tag in your ".container", instead of a <div> tag.

  I think it's easier to center the card with a grid display (only 2 lines needed), but the end result is the same.

  You also don't need the card to be a flex, since the normal flow of blocks is vertical.

  0

  ---

  

  Evelyn Matos•80

  @evelyn-matosPosted about 2 years ago

  @ralacerda Obrigada por colaborar... vou aplicar suas dicas :)

  0