@vladmeeSubmitted over 1 year ago
Latest comments
- @JasonPBurkePosted 1 day ago
I like this solution! The only thing I would consider changing is the change on screen size. You may consider switching away from the mobile design at a smaller size (say 768px) as it can look a bit strange stretched out up to 1000px.
Cheers!
0 - @haman1Submitted over 2 years ago@JasonPBurkePosted 11 days ago
This looks pretty good! In your profile class, you might think about wrapping the image and details in a div and then you can position the share button and the profile at opposite ends of the div.
Cheers0 - P@amancalledkiddSubmitted 14 days agoWhat are you most proud of, and what would you do differently next time?
This was my second attempt at cube css, found that a good setup of globals really layed a solid foundation for the rest of the project. Next time i would focus on better understanding and application of utilites.
What challenges did you encounter, and how did you overcome them?The desktop layout I found I challenging when using
What specific areas of your project would you like help with?grid-template-columns&grid-template-rows. To get a better understanding of my layout, I usedgrid-template-areaswhich allowed me to create the desired solution.Tips on Cube css?
Any suggestions or recommendations?
- @Tauya2003Submitted about 2 years ago@JasonPBurkePosted 14 days ago
This looks great. I think the <p> fonts should be the Grey-400 and Grey-500 outlined in the style guide. 400 for the card paragraphs and 500 for the header paragraph.
Cheers
0 - @heixiaozhiSubmitted 17 days agoWhat are you most proud of, and what would you do differently next time?
using scss
What challenges did you encounter, and how did you overcome them?using scss and grid layout
What specific areas of your project would you like help with?code review
@JasonPBurkePosted 15 days agoThis looks really good!
Perhaps rather than using an <a> tag, you could use a <button> tag.
Also, if you use {max-inline-size: 100%} on your image when in mobile you will be able to lock the image to the container without it overflowing.
Marked as helpful0 - @YhummSubmitted 28 days ago@JasonPBurkePosted 18 days ago
Looks good but look in to creating a styles.css file and including it in your HTML with a <link>. Look at the @font-face to help you import and use the correct fonts needed for the page.
0
