
responsive product preview card using sass
Design comparison
Community feedback
- P@lenny131Posted 10 days ago
Good job on your solution. It looks like the design, and the layout changes correctly with the width of the browser window.
Something you might want to be careful about is the way you use both rem and px for sizing. The page looks correct when the browser's default font size is 16px, and the zoom function works fine as well. However, when changing font size in the browser settings, some of the text resizes, like the header and price, but the description stays at 14px.
One other minor suggestion is to consider moving the button's
transition
property directly under thebutton
selector, rather than underbutton:focus, button:active, button:hover
. As it is right now, the color transition only works when entering the hover (and other) states, but, when exiting, the color changes instantly instead of using the transition.Marked as helpful1@JasonPBurkePosted 10 days ago@lenny131 thank you! I could not for the life of me figure out why the ease out part of the transition would not cooperate. And the comment on font sizing problem is spot on. Cheers
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord