A ton of work. I expect it would be somehow fast and easy but next is working quite different than regular js/css/react. I still can't figure out how to animate svg for burger menu, but that's simple in usual project. Even for this i used a library that implements burger as a bunch of div's. I really enjoy this challenge, so wish everyone to challenge this. =)
Ígor Haag
@HaaguitosAll comments
- @ArmsAndArrowsSubmitted over 1 year ago@HaaguitosPosted over 1 year ago
Hey, Shchetkov!
Awesome solution! The smooth animations and redirects make it a great experience browsing through your website, and I really like how you made the application icon redirect to the homepage (believe me, not everybody does that)!
I'll leave some points here as a feedback:
- On the tecnology tab, the image could have more spacing between it and the text on web devices, since there is a big free space on the right;
- still on technology tab, but on cellphones, there is no spacing between the texts, and some gap could increase the readability;
- on the crew tab, the images don't have fixed size, so the screen jumps when changing to Douglas Hurley, caused by the scrollbar appearing.
Hope it helps!
0 - @jordanheveSubmitted over 1 year ago
I really liked how the slider works on desktop, but I'm not convinced about using it on mobile. I would be thankful if someone could recommend me slider libraries for React. Any suggestions to improve my code are welcome.
@HaaguitosPosted over 1 year agoHello, Jordan!
Nice solution. The slider really solves some problems with the images on mobile and tablet, where it's harder to click and some of the animations are on point (but a bit too agressive, in my opinion).
I have some points that bothers me a little while using the application, so I'll leave it here as a feedback:
- Application icon (fixed on the left side of the header) could be used to redirect to homepage;
- on tablet sizes, the blured section of the header overlaps the scrollbar;
- still on tablet sizes, tech images could fill some more space of the screen (maybe 100% of the width?);
- on laptop sizes, font sizes are very big, even for full HD resolutions.
Marked as helpful1 - @coderdannieSubmitted over 1 year ago
Making this website responsive was a bit challenging for me with took me quite a long to complete. This is my first time building a project using react-router and I really learn extensively. The images in the data.json are broken so I had to use all other contents in the data.json except the pictures together with the local pictures provided so I manually inserted the pictures into the dom using ternary operators. This is the area of the code am not sure of although it worked quite perfectly. Am open to suggestions on how I can also improve my code as I believe that learning never stops. THANKS
@HaaguitosPosted over 1 year agoAmazing work, Emmanuel!
One thing I could say is that, in your crew page (all device sizes), the buttons move when the crew changes, so we end up having a troublesome experience. But, besides that, it's all nice!
1