Design comparison
Solution retrospective
Making this website responsive was a bit challenging for me with took me quite a long to complete. This is my first time building a project using react-router and I really learn extensively. The images in the data.json are broken so I had to use all other contents in the data.json except the pictures together with the local pictures provided so I manually inserted the pictures into the dom using ternary operators. This is the area of the code am not sure of although it worked quite perfectly. Am open to suggestions on how I can also improve my code as I believe that learning never stops. THANKS
Community feedback
- @HaaguitosPosted over 1 year ago
Amazing work, Emmanuel!
One thing I could say is that, in your crew page (all device sizes), the buttons move when the crew changes, so we end up having a troublesome experience. But, besides that, it's all nice!
1@coderdanniePosted over 1 year ago@Haaguitos thanks for the feedback. I tried as much as possible to prevent that from happening but the problem is that the images seems wey bigger than one another which created the issue. I will definitely find a nifty solution to that.
1@HaaguitosPosted over 1 year ago@coderdannie
One solution could be defining the height/width properties so the image will aways be that size, not pushing or pulling the other elements on the screen! There are a lot of ways to do that too, like using aspect-ratio or making container divs.
Marked as helpful0 - @DaniJFerreiraPosted over 1 year ago
Hey Emmanuel,
Very nice your planet animations! good job! keep going !!!!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord