Skip to content
OverviewSolutions
8
Comments
9
GrischK
@GrischK

All comments

  • PhoenixDev22•16,950
    @PhoenixDev22Submitted almost 3 years ago

    Hello community, I've completed another frontend mentor , I had a challenging time making it.

    I have a question about setting max-width to body that the website doesn't stretch all on larger desktops (more than 1440px) , and the design messes up.

    Any suggestions about the accessibility?

    Please share your thoughts !There’s still some more to do like the readme, cleaning up repeating code, and html warnings.

    I'd appreciate any comments for improvements or anything I've missed. Thank you!

    Frontend-Mentor-Blogr using HTML CSS JS

    3
    GrischK•140
    @GrischKPosted almost 3 years ago

    Excellent job, it looks very similar to the original design and the responsive is nice.

    Marked as helpful
    0
  • PhoenixDev22•16,950
    @PhoenixDev22Submitted almost 3 years ago

    Hi everyone, had a challenging time with this one from start to finish.

    My struggles, and bugs:

    • toggle menu icon javascript only works on the second and subsequent clicks. not on the first .Any suggestions?
    • I just noticed that the next and previous buttons are not working on the live solution while they are working on the live server, I've tried so many times .no idea how this bug did occur?

    I don’t know for sure if the images fit the screen . Please let me know if you find any overflow or other quirks with the images.

    I'm still learning about accessibility .

    In javascript , I used more basics ways.

    Please share your thoughts! Had a great time working on the CSS, the image grid was a new challenge for me. There’s still some more to do like the readme, cleaning up repeating code, and html warnings.

    I'd appreciate any comments for improvements or anything I've missed. Thank you!

    Frontend-Mentor-E-commerce-product-page HTML CSS JS

    4
    GrischK•140
    @GrischKPosted almost 3 years ago

    Very good job !!!

    0
  • GrischK•140
    @GrischKSubmitted almost 3 years ago

    Hi everybody. I have a problem with the responsive between 1228px and 800px. My blocks are going to the right instead reducing as I set with 60%... In the mean time I don't understand why my body height doesn't fit with content... Any advise ?
    Thanks ;)

    Using Grid

    2
    GrischK•140
    @GrischKPosted almost 3 years ago

    I don't understand why on responsive version my HTML and Body elements are not taking all the page... If you have any advise or solution I would thank you guys ;)

    0
  • Florian•50
    @Flojo994Submitted almost 3 years ago

    Hey Ya! Another one for review. Any feedback is welcome. I would appreciate feedback especially for reducing code (Section "Color changes to individual cards" in CSS - There must be cleaner way to write that :) and the responsiveness also feels a bit mechanical (Any suggestion to make it smoother?). Thanks already! Cheers Flo

    Responsive Testimonials grid section

    1
    GrischK•140
    @GrischKPosted almost 3 years ago

    Hi, good job, nice result. I don't see issue with the responsive, but I'm begginer. I think it misses margin on the bottom. Congratulations.

    1
  • GrischK•140
    @GrischKPosted almost 3 years ago

    Well done, very good job !!! I think you can improve the result with the title font and background. Congratulation.

    Marked as helpful
    0
  • GrischK•140
    @GrischKPosted almost 3 years ago

    Great job Mateja (especially for the shadow, I will have a look on your code for it). You can improve the details with border-radius ;). Congrats !

    Marked as helpful
    0
  • Nick OD•270
    @NickODxyzSubmitted almost 3 years ago

    Hi all, please let me know if the image overlay could have been done different or in anyway better.

    Any feedback from anyone on my work is much appreciated.

    Thanks, Nick

    NFT Preview Card | Image Overlay

    2
    GrischK•140
    @GrischKPosted almost 3 years ago

    What a perfect job Nick !!! Even the size looks perfect, amazing ;)

    1
  • John Idenyi•250
    @JohnIdenyiSubmitted almost 3 years ago

    Hello everyone! I think my major problem was trying to make the background the same with the design but unfortunately I couldn't. Open to suggestions how to position my background properly.

    Profile Card Component

    2
    GrischK•140
    @GrischKPosted almost 3 years ago

    Good job man ! That's clean and similar to the design.

    0
  • GrischK•140
    @GrischKPosted almost 3 years ago

    Good job !!!

    0