P
@makogeborisSubmitted 9 months ago
Gakii
@G-GakiiAll comments
- @outHereSamSubmitted 7 months ago@G-GakiiPosted 7 months ago
Hello @outHereSam.Great work finishing the challenge. your may consider this for improvement:
-
On Safari website your cart appears to be a little bit smaller but on Chrome it looks nice you may consider adding min-width
Marked as helpful0 -
- @obed-smartSubmitted over 1 year ago@G-GakiiPosted 7 months ago
- Hello @obed-smart .This is nicely done. For improvement, you can consider below
- Background and foreground colours do not have a sufficient contrast ratio. you can use the lighthouse to check this.
Marked as helpful0 - @edwinc73Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I started breaking down reusable elements from the start such as button, section, section title this did help me to style and build the site quicker however I have to admit that some of it was overkill for a static page.
additionally I had to change some styling elements because they did not pass the contrast test for acccessibility
What challenges did you encounter, and how did you overcome them?I kept trying to adjust the blue pill background with fixed css units, eventually found that percentages worked best
What specific areas of your project would you like help with?Any feed back :D
- @rajjubajraSubmitted over 1 year ago@G-GakiiPosted 7 months ago
-
Congratulations on finishing this challenge—it looks fantastic!
-
For further improvement, you can use Lighthouse to evaluate accessibility. The buttons in AngleArrowLeft.js and AngleArrowRight.js currently lack accessibility. Consider adding an aria-label attribute to these buttons to provide a clear and descriptive name.
-
The title also gives screen reader users an overview of the page, and search engine users rely on it heavily to determine if a page is relevant to their search. this will also improve your seo
0 -
- @edwinc73Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Using context api and media query hook
What specific areas of your project would you like help with?Any help would be useful, specially how to layout the page more efficiently
@G-GakiiPosted 7 months agoHey wonderfully executed
- For copyright, you can use HTML entities or the © symbol.
0 - @edwinc73Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I was hesitant to use tailwind as I have grown quite used to bootstrap. However now that I have used it I can definetely see the advantages. I will be continue to master tailwindcss from now on.
What challenges did you encounter, and how did you overcome them?Most of the challenges i encounter was about the pseudo elements. I think at some point it was easier and more readable to just style it in css.
What specific areas of your project would you like help with?Any feedback is welcomed!
@G-GakiiPosted 7 months agoHey, this is well-built!
For improvement, you might want to consider adding a descriptive alternative description for the image to enhance accessibility.
1 - @edwinc73Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
For the sidebar I tried to use boostrap however i realised this was not going to work as well. I then tried to use react to conditionally render the inline menu or side nav. I also used framer motion to gentlely fade the overlay which took a few tries.
What challenges did you encounter, and how did you overcome them?Had some visual bugs with the overlay and images not rendering properly. Solved it by naturally moving the faded background under everything.
What specific areas of your project would you like help with?improvements on accessiblity :D
- P@HekimianzSubmitted 8 months ago
- P@HekimianzSubmitted 8 months ago
- @minnaingkokoSubmitted 8 months ago@G-GakiiPosted 8 months ago
Hi @minnaingkoko, great job! Unfortunately, I can't provide a detailed review because I'm not very familiar with Svelte.
Marked as helpful0 - @MrSeagerSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Weel it is working
What challenges did you encounter, and how did you overcome them?Challenges wasn't hard to talk about it
What specific areas of your project would you like help with?I still need help with typescript I'm not sure if I am using it correctly
- @Ay-dotcodeSubmitted 8 months ago@G-GakiiPosted 8 months ago
Hey great work. -Your code fine but you can consider below:
-The email validation is quite basic. For better validation, consider using regular expressions. -If you want the validate function to handle submission you would, you rather use the submit event of the form rather than a button click.
0 - @bossthekhaniSubmitted 9 months agoWhat are you most proud of, and what would you do differently next time?
I am most proud to start learning node js .
@G-GakiiPosted 8 months agoHello, Fantastic work. However, you might have styled your work using a CSS file, changing the background colour and font family, for example.
0 - @LucasNgTgSubmitted 8 months ago
- @GoddaybcSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I am very proud to finally be able to complete this site. i finish the html and structure the mobile like four days ago except the desktop part which game me so much pain
What challenges did you encounter, and how did you overcome them?How to place the four cards in the columns and role so that they can align the the way they displayed i was unable i started learning css grid untill someone show me the code and i understood it
What specific areas of your project would you like help with?Grid is my problem haven't understand it fully but i will
@G-GakiiPosted 8 months agoWell done. -Consider watching CSS Grid by Net Ninja on YouTube to gain a better knowledge of Grid.
Marked as helpful0 - P@aysenurtatliSubmitted 9 months ago@G-GakiiPosted 8 months ago
Hi, that's a good website, but for ease of debugging and reusability, you might want to think about splitting the html and css files next time.
0 - @JUNEDSKSubmitted 10 months agoWhat are you most proud of, and what would you do differently next time?
Hey there! I just wanted to let you know that I created this one using internal css, and I'll be taking care of the external next time. For the styling, I'm using an online CDN, but I'll make sure to add it to the system next time.
What challenges did you encounter, and how did you overcome them?Just a heads-up to let you know that this card is a bit larger than before. It looks like there's plenty of styling to do, but it's going to be easy and good to go. Cheers!
What specific areas of your project would you like help with?just wanted to confirm that the padding and margin height for the hero sections are good. That's all I need your help with. Thanks!
@G-GakiiPosted 9 months agoHello, your HTML structure is good, however, there might be room for improvement. For instance, the use of the <p> tag inside <li> elements is not semantically incorrect, but it’s not the most efficient approach. <p> tags are block-level elements intended for paragraphs of text, while list items (<li>) are already block-level and can contain text directly.i think this approach is better.
<li><strong>Total</strong>: Approximately 10 minutes</li> <li><strong>Making</strong>: 5 minutes</li> <li><strong>Cooking</strong>: 5 minutes</li> </ul>``` Additionally, you might think about arranging CSS in the HTML structure to improve readability and maintainability. I don't see any problems with the padding and margins in your hero section.Marked as helpful0
