@mkborisSubmitted 4 months ago
Gakii
@G-GakiiAll comments
- @outHereSamSubmitted 3 months ago@G-GakiiPosted 2 months ago
Hello @outHereSam.Great work finishing the challenge. your may consider this for improvement:
-
On Safari website your cart appears to be a little bit smaller but on Chrome it looks nice you may consider adding min-width
0 -
- @obed-smartSubmitted over 1 year ago
i learned a lot about responsiveness in this project though it was had to me as a beginner
@G-GakiiPosted 3 months ago- Hello @obed-smart .This is nicely done. For improvement, you can consider below
- Background and foreground colours do not have a sufficient contrast ratio. you can use the lighthouse to check this.
0 - @edwinc73Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I started breaking down reusable elements from the start such as button, section, section title this did help me to style and build the site quicker however I have to admit that some of it was overkill for a static page.
additionally I had to change some styling elements because they did not pass the contrast test for acccessibility
What challenges did you encounter, and how did you overcome them?I kept trying to adjust the blue pill background with fixed css units, eventually found that percentages worked best
What specific areas of your project would you like help with?Any feed back :D
- @rajjubajraSubmitted 11 months ago@G-GakiiPosted 3 months ago
-
Congratulations on finishing this challenge—it looks fantastic!
-
For further improvement, you can use Lighthouse to evaluate accessibility. The buttons in AngleArrowLeft.js and AngleArrowRight.js currently lack accessibility. Consider adding an aria-label attribute to these buttons to provide a clear and descriptive name.
-
The title also gives screen reader users an overview of the page, and search engine users rely on it heavily to determine if a page is relevant to their search. this will also improve your seo
0 -
- @edwinc73Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Using context api and media query hook
What specific areas of your project would you like help with?Any help would be useful, specially how to layout the page more efficiently
@G-GakiiPosted 3 months agoHey wonderfully executed
- For copyright, you can use HTML entities or the © symbol.
0 - @edwinc73Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I was hesitant to use tailwind as I have grown quite used to bootstrap. However now that I have used it I can definetely see the advantages. I will be continue to master tailwindcss from now on.
What challenges did you encounter, and how did you overcome them?Most of the challenges i encounter was about the pseudo elements. I think at some point it was easier and more readable to just style it in css.
What specific areas of your project would you like help with?Any feedback is welcomed!
@G-GakiiPosted 3 months agoHey, this is well-built!
For improvement, you might want to consider adding a descriptive alternative description for the image to enhance accessibility.
1 - @edwinc73Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
For the sidebar I tried to use boostrap however i realised this was not going to work as well. I then tried to use react to conditionally render the inline menu or side nav. I also used framer motion to gentlely fade the overlay which took a few tries.
What challenges did you encounter, and how did you overcome them?Had some visual bugs with the overlay and images not rendering properly. Solved it by naturally moving the faded background under everything.
What specific areas of your project would you like help with?improvements on accessiblity :D
- @HekimianzSubmitted 3 months ago
- @HekimianzSubmitted 3 months ago
- @minnaingkokoSubmitted 4 months ago@G-GakiiPosted 3 months ago
Hi @minnaingkoko, great job! Unfortunately, I can't provide a detailed review because I'm not very familiar with Svelte.
Marked as helpful0 - @MrSeagerSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Weel it is working
What challenges did you encounter, and how did you overcome them?Challenges wasn't hard to talk about it
What specific areas of your project would you like help with?I still need help with typescript I'm not sure if I am using it correctly
