Design comparison
Solution retrospective
Hey there! I just wanted to let you know that I created this one using internal css, and I'll be taking care of the external next time. For the styling, I'm using an online CDN, but I'll make sure to add it to the system next time.
What challenges did you encounter, and how did you overcome them?Just a heads-up to let you know that this card is a bit larger than before. It looks like there's plenty of styling to do, but it's going to be easy and good to go. Cheers!
What specific areas of your project would you like help with?just wanted to confirm that the padding and margin height for the hero sections are good. That's all I need your help with. Thanks!
Community feedback
- @G-GakiiPosted 4 months ago
Hello, your HTML structure is good, however, there might be room for improvement. For instance, the use of the <p> tag inside <li> elements is not semantically incorrect, but it’s not the most efficient approach. <p> tags are block-level elements intended for paragraphs of text, while list items (<li>) are already block-level and can contain text directly.i think this approach is better.
<li><strong>Total</strong>: Approximately 10 minutes</li> <li><strong>Making</strong>: 5 minutes</li> <li><strong>Cooking</strong>: 5 minutes</li> </ul>``` Additionally, you might think about arranging CSS in the HTML structure to improve readability and maintainability. I don't see any problems with the padding and margins in your hero section.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord