@IgnatiusVisnuSubmitted about 2 years ago
Latest solutions
Latest comments
- @FabianWassermannPosted about 2 years ago
First of all, you did a great job! I looked at your code and found why it was difficult for you to control the spacing.
You used % for nearly everything. I prefer using rem instead. It gives you better control and for smaller devices you can use media queries. You can give the card a max-width so that the card can not get bigger at some point but can always get smaller. Let the content inside of the card decide how big your card gets. When you use px, em or rem for the padding it will be much easier to control.
I hope this helps. 😉
0 - @bacigala25Submitted about 2 years ago@FabianWassermannPosted about 2 years ago
Great work! Very clean! I only found one point to improve.
- Implement the seperator as shown in the design.
Keep it going!
Marked as helpful0 - @myrealstorySubmitted about 2 years ago@FabianWassermannPosted about 2 years ago
Great work! Here are some points for improvement.
- You can make the card much wider.
- Use bigger padding to let the content breath.
- I would recommend using landmarks like <main>, <content> or <header>.
Keep it going!
0 - @japhielxSubmitted about 2 years ago@FabianWassermannPosted about 2 years ago
Great work! Here are some points for improvement.
- The qr-image should have a small border radius.
- You can use more padding to let the content breath.
- Regarding your code I have to say that the landmark main should wrap your whole modal and the heading should be wrapped in an h1-tag.
Keep it going!
Marked as helpful0 - @mygodefiSubmitted about 2 years ago@FabianWassermannPosted about 2 years ago
Great work! Here are some points for improvement.
- You should use a bigger border radius on the card as on the image.
- The card of the design has not border and a slight shadow effect.
I can not look at your code because you linked the wrong repo.
Keep it going!
0 - @JosueFreakSubmitted about 2 years ago@FabianWassermannPosted about 2 years ago
Great work! Here are some points for improvement.
- You should not use such a hard shadow in this case.
- The text should be centered.
- You can use a bigger border radius on the card element.
Keep it going!
0
