Alex• 50
@alexvdc
Submitted
Is this good enough ?
Any feedback are welcome !
Daniel Brož
@DanoBroz
All comments
- Daniel Brož• 40
@DanoBroz
Posted
Hey Alex,
I like it, you've made your code readable and kept the consistency through out the whole project.
There's one pinpoint I found, since you're using grid and flexbox I'd suggest to use images as background of elements and set their background-position, repeat and so on, so they'll keep same ratio. For simple and quick use, you can add style shorthand like this: background: url('image-url') center / cover no-repeat;
0 - Trenton Bensheimer• 190
@tbensheimer
Submitted
Hey everyone I completed another Junior Project with an API. This project was really fun to build as I have learned a way to toggle between themes. I also utilized a different solution to fetch the API than the previous advice generator project. Another concept I learned was being able to use the slice method in JavaScript to eliminate the unnecessary information that was retrieved from the API (specifically the date the users have joined). Please let me know if there is any way I could improve my code! Thank you in advance.
Daniel Brož• 40@DanoBroz
Posted
Hi Trenton, I love that you've chosen a mobile-first approach and were able to set this up with VanillaJS. Firstly, as a friendly colleague FE developer, I'd suggest to be more aware of the colours, shadows and paddings provided in the design file, it gives a lot more value and refers how much you care about the project. Secondly, with APIs there's always a chance of some data not being provided, so I'd look into nullability with promises.
Marked as helpful
0 - Jordan Phillips• 425
@JordanPhillips-hub
Submitted
Daniel Brož• 40@DanoBroz
Posted
It's nice you've selected the mobile first approach, but It seems you forgot about desktop view. In the design provided you can find that the content of the app is 730px wide on the desktop (so just like in your breakpoints it would be 768px up). I'd suggest to add other breakpoint rules ex. between 481px — 768px - tablet and implement desktop view for higher breakpoint.
0
