news-homepage-main

Community feedback

• 

  Anh Tuấn Bùi•240

  @anhtuanbuiPosted about 2 years ago

  Hi Alex,

  Your solution look good. However, there are some things that you may want to improve.

  • Your grid, your third section does not align well with the one above.
  • Your images are not fitting well. You can use object-fit: cover for images.
  • Your background color in the middle is different from two side.

  0

  ---

  

  Alex•50

  @alexvdcPosted about 2 years ago

  @anhtuanbui I completely forgot to take off the "max-width" of my second container, everything should by fine for the grid side now.

  And for images and background color I didn't notice something was wrong, I corrected theses parts too, thank you !

  0
• 

  Daniel Brož•40

  @DanoBrozPosted about 2 years ago

  Hey Alex,

  I like it, you've made your code readable and kept the consistency through out the whole project.

  There's one pinpoint I found, since you're using grid and flexbox I'd suggest to use images as background of elements and set their background-position, repeat and so on, so they'll keep same ratio. For simple and quick use, you can add style shorthand like this: background: url('image-url') center / cover no-repeat;

  0

  ---

  

  Alex•50

  @alexvdcPosted about 2 years ago

  @DanoBroz Thank you for your feedback !

  I tried to use images as background but it didn't works as well I was expected, or maybe I had to change some parts of code for that... But I will try your suggestion for the next projects ! For now, "object-fit" did the job :)

  0
• 

  samlobeng•50

  @samlobengPosted about 2 years ago

  It's perfect. Good job!

  0

  ---

  

  Alex•50

  @alexvdcPosted about 2 years ago

  @samlobeng Thank you !

  0