brukmg• 120
@brukmg
Submitted
P
Danny
@DannyGuerin
All comments
- Gobinath• 140
@gopinath-97
Submitted
What are you most proud of, and what would you do differently next time?
I have completed this one already a long time ago and was saved in my system, but didn't update to git. After few alters I hope it looks almost match to the image given.
What specific areas of your project would you like help with?
Hi all, please share your valuable feedbacks on the code where I can improve and what needs to be choosen as best practice which I will incorporate in the upcoming solutions.
Hello, this is looking really good. Here are a few things I noticed: There needs to be a bit more padding around the Preparation time div.
Increase the line height on the ol and ul elements and there needs to be some spacing between the bullet point/number and the text.
You definitely did better than me on this challenge, and I hope this helps. :-)
Marked as helpful
0 - Ben Chi• 80
@BenTheChi
Submitted
What are you most proud of, and what would you do differently next time?
Used Flexbox a lot for this. Really like that it's forcing me to practice it more.
What challenges did you encounter, and how did you overcome them?
Spacing, font, and image sizing I had to eyeball since I don't have the pro version with the Figma specifications. It's not exactly right but I think it's close enough.
What specific areas of your project would you like help with?
Spacing/font sizing suggestions. Did I use Flexbox correctly? Or are there other ways I could have aligned things that are more elegant?
Hey Ben. Seeing as you had to eyeball this, it's looking pretty decent. Here are a few things that I noticed:
-
The card looks smaller than the design and the padding around the edges could be a little thicker... Unless you were just focusing on the mobile version, in which case, cool.
-
Check out media queries for your CSS to make the build work on all devices. They are pretty easy to add and will make it look better everywhere.
Hope this helps. :-)
1 -
- Edith• 50
@ShiRaw11
Submitted
Hello Edith, this is looking good. I noticed only a few little things, but everything else looks on point.
-
It's not a big deal, but instead of just using classes in the HTML, try out IDs, too. Classes can be used multiple times, and IDs only once.
-
The Avatar at the bottom looks a little indented and not in line with the rest of the content. I think it might be the padding ;-)
I hope this helps.
Marked as helpful
0 -
- Simsim99• 70
@Simsim99
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of how quick i managed to make the main design !
What challenges did you encounter, and how did you overcome them?
I had to center the text and image using margins at first,which i found difficult but after a quick research i used flex instead !
What specific areas of your project would you like help with?
when to align the items and how to center elements,which selectors to rely on and wich to AVOID!
Hey Sim, it's looking good. Here's a few quick things I noticed:
- I'm unsure if it's my screen, but does the background color look a little different to the design?
- The size of your card is smaller than the design.
- Be sure to check the font colors for your text, as they look a little darker than the design.
Marked as helpful
0
