Implemented hover effects for the card and text heading.

Community feedback

• 

  Begli Amanov•80

  @begli-amanovPosted about 1 month ago

  Hi @ShinRaw11, a really nice work here. Especially I found the Idea to work with flexbox and use gap property with it very interesting. I have even implemented it in my own solution from this challenge. There are however few suggestions I could give:

  • Most important thing I guess is the multiple use of <h1> heading. It usually used as a page hero section (content description). It should be used just once per page. You could read here a bit about it.

  • It might be not the best stuff to use fixed heights on the elements and let them expand naturally. You could stumble on overflow issue. It this case it is not so important, but it might once. I would suggest to avoid them unless you really need.

  Nevertheless it is really good job. I've learned few stuff from your solution so my big appreciation for that! Keep up the good work and have fun on your journey!

  Marked as helpful

  0
• 

  P

  Danny•110

  @DannyGuerinPosted about 2 months ago

  Hello Edith, this is looking good. I noticed only a few little things, but everything else looks on point.

  • It's not a big deal, but instead of just using classes in the HTML, try out IDs, too. Classes can be used multiple times, and IDs only once.

  • The Avatar at the bottom looks a little indented and not in line with the rest of the content. I think it might be the padding ;-)

  I hope this helps.

  Marked as helpful

  0