Siddharth• 230
@siddharth-1407
Submitted
This was my first time testing Media Queries. All feedback are welcome. If you have any suggestion on how I can improve it, feel free to leave your comments! Thank you!
Didia Uchenna
@D-KILLJOY
All comments
- Didia Uchenna• 400
@D-KILLJOY
Posted
You did a really good job, It's responsive. But it's showing an error because you put a (section) element inside your (button) which isn't supposed to be so and the mobile view always try to add some (Padding) or (margin) so that it doesn't rest directly on the edge, I nested mine in a (main) element and used flex-box to center it, that's a suggestion for a fix and remove the (section) element that's nested inside the button element.
Marked as helpful
1 - Siddharth• 230
@siddharth-1407
Submitted
This is my first project, and i really don't understand when to use which unit so i went through a try and error hell trying to guess the size of my card. I want to know if its a normal thing for everyone or its just me? Any recommendation or advice is welcome i want to learn!
Didia Uchenna• 400@D-KILLJOY
Posted
I usually use (rem) units but first i set the font-size in the root element to 62.5% which is same thing as 10px so that way 1rem == 10px and 1.6rem == 16px I'll recommend trying to use rem units
Marked as helpful
1 - yookateoh• 220
@dhdbrud318
Submitted
I would appreciate any feedback!
Didia Uchenna• 400@D-KILLJOY
Posted
This is awesome, Try wrapping the eth logo and the price in a (div) and use flexbox for it so it stays on the same line use "align-items:center" do the same thing for the time left too
1 - Justin Diaz• 40
@Jad229
Submitted
- Using flexbox how can I bring the crossed-out price next to the new price?
- I still struggle with making content spread evenly throughout all screen sizes any tips?
Didia Uchenna• 400@D-KILLJOY
Posted
Wrap both in a (div) and set display to flex, then use "align items: center" and they would placed side by side. you can use the gap property to create a little space between them.
Marked as helpful
0
