Design comparison
Solution retrospective
This is my first project, and i really don't understand when to use which unit so i went through a try and error hell trying to guess the size of my card. I want to know if its a normal thing for everyone or its just me? Any recommendation or advice is welcome i want to learn!
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Siddharth, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:
Something I've noticed in your code is that in many occasions you've added some
<div>to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be<div>or<main>if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>✌️ I hope this helps you and happy coding!
Marked as helpful1@siddharth-1407Posted about 2 years ago@correlucas Initially i didn't use a MAIN tag but then it showed an issue saying there should be a main tag so i edited it. I struggle a lot when it comes to structure of a website and end up writing unnecessary HTML like i did. Thanks for your comment, i really needed someone to help me with this.
1 - @D-KILLJOYPosted about 2 years ago
I usually use (rem) units but first i set the font-size in the root element to 62.5% which is same thing as 10px so that way 1rem == 10px and 1.6rem == 16px I'll recommend trying to use rem units
Marked as helpful1@siddharth-1407Posted about 2 years ago@D-KILLJOY Thanks! ill try make some more projects using (rem) units.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord