@correlucas
Posted
👾Hello Siddharth, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!
I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:
Something I've noticed in your code is that in many occasions you've added some <div>
to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div>
or <main>
if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
✌️ I hope this helps you and happy coding!
Marked as helpful
@siddharth-1407
Posted
@correlucas Initially i didn't use a MAIN tag but then it showed an issue saying there should be a main tag so i edited it. I struggle a lot when it comes to structure of a website and end up writing unnecessary HTML like i did. Thanks for your comment, i really needed someone to help me with this.