Product Preview Card

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Justin, Congratulations on completing this challenge!

  Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

  Your component is okay but its missing the vertical alignment. The best way to do it is by using flexbox. First step is to add min-height: 100vh to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body and then use the flex properties for alignment with display: flex / align-items: center; / justify-content: center;

  section {
      min-height: 100vh;
      /* margin-top: 7rem; */
      display: flex;
      align-items: center;
      justify-content: center;
  }
  

  THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Justin Diaz•40

  @Jad229Posted about 2 years ago

  @correlucas Wow I did not know about the picture tag, for sure going to look into that thank you!

  0
• 

  Didia Uchenna•400

  @D-KILLJOYPosted about 2 years ago

  Wrap both in a (div) and set display to flex, then use "align items: center" and they would placed side by side. you can use the gap property to create a little space between them.

  Marked as helpful

  0

  ---

  

  Justin Diaz•40

  @Jad229Posted about 2 years ago

  @D-KILLJOY Oh thank you im going to try that

  0

  

  Didia Uchenna•400

  @D-KILLJOYPosted about 2 years ago

  @Jad229 You're welcome.

  0