Skip to content
OverviewSolutions
32
Comments
6
CodingTube
@CodinGitHub

All comments

  • CodingTube•510
    @CodinGitHubPosted over 1 year ago

    Nice solution! Perhaps I could suggest reserving the h1 tag for an entire section. In this case, since it's a card, you could use h2...h6 tags instead.

    Using a naming methodology like BEM to give names to classes can also help you maintain your code readability.

    Marked as helpful
    0
  • CodingTube•510
    @CodinGitHubPosted over 1 year ago

    Hi! Great solution! Just one thing I'd like to point out: the style tag is not necessary if you have a stylesheet. I recommend removing it and placing the styles from this tag into the styles.css file. This approach will keep your code cleaner and more organized. Happy coding!

    Marked as helpful
    1
  • CodingTube•510
    @CodinGitHubPosted over 2 years ago

    Thank you very much for your feedback! I decide to use margin to every single element because if I use padding in the card container the image doesn't fit to the 100% of the width of the card and I don't like to use position absolute to do that. Do you know another way to achieve the image use all the width of the container even if the container have a padding?

    1
  • CodingTube•510
    @CodinGitHubPosted over 2 years ago

    Hi Vanza thank you very much for your feedback. I really appreciate it. This will help me improve my developer's skill a lot.

    0
  • CodingTube•510
    @CodinGitHubPosted almost 3 years ago

    Hi! thank you very much for the feedback

    1
  • CodingTube•510
    @CodinGitHubPosted almost 3 years ago

    Good Job! I see that you're using variables in CSS. That's a good practice. 👏👏👏

    0