Ebube Amadi• 130
@ebubz-dev
Submitted
Sadik Rahman
@Coder-Sadik
All comments
- Sadik Rahman• 190
@Coder-Sadik
Posted
Mobile and desktop screens look good, but you should also make the design responsive for tablet screens.
0 - Ebube Amadi• 130
@ebubz-dev
Submitted
Sadik Rahman• 190@Coder-Sadik
Posted
Great solution. I have also learned a new way using grid from your code. Only the thing I can say, the horizontal gaps between columns in big screen can be changed.
Marked as helpful
0 - Md Naimur Rahman• 100
@mdnaimur
Submitted
Sadik Rahman• 190@Coder-Sadik
Posted
Great job, the card dimension looks precise.
1 - Dmino228• 90
@Dmino228
Submitted
Sadik Rahman• 190@Coder-Sadik
Posted
This HTML and CSS code is well-structured, clean, and adheres to best practices. The use of custom CSS variables for color management is efficient, and the typography choices complement the recipe page's aesthetic. The layout is responsive, with media queries ensuring good display on smaller screens. The semantic use of HTML elements like <main>, <h1>, and <p> enhances accessibility.
0 - YEISON• 50
@jeimos
Submitted
Sadik Rahman• 190@Coder-Sadik
Posted
Your code is well-organized and responsive, with a clear structure for both desktop and mobile views. The use of CSS for consistent styling is effective, but consider using relative units (like
emor%) for the body width to enhance flexibility. The hover effects are well-implemented, adding a nice interactive touch. You could improve accessibility by adding alt text for the buttons and ensuring color contrast meets accessibility standards. Overall, it’s a solid implementation with minor adjustments needed for scalability and accessibility.0 - Alexander Roan• 100
@dearestalexander
Submitted
What are you most proud of, and what would you do differently next time?
I decided to try and go a bit further than the template and add a second verison with colour and content adjustments. I used JavaScript to do this. I found this experience useful as I learnt a little bit about inheritence and precedence when trying to switch styles between CSS items with id selectors using classes. I also hadn't realised getElementByClassName returned a live collection vs. documentQuerySelectorAll returning a static nodelist.
What challenges did you encounter, and how did you overcome them?
Just getting used to precedence.
Was initially a bit unsure on whether to use alternate classes in CSS for styling changes or whether to hard code the alternate styles values in JavaScript. I decided on the former approach as I think it's easier to manage future style adjustments if all style factors are in CSS. I think the content changes have to be hardcoded into JavaScript, at least without having a database?
What specific areas of your project would you like help with?
Wondering if my JavaScript approach is relatively efficient or if there are better ways to do this?
Sadik Rahman• 190@Coder-Sadik
Posted
Adding alternative design is really appreciated. Your code handles the style toggle effectively, updating elements like name, location, bio, and social links. The use of CSS variables for colors and font sizes ensures consistency and maintainability. The design is responsive, with a media query to handle smaller screens.
Marked as helpful
0 - Nostromito• 190
@Nostromito
Submitted
What are you most proud of, and what would you do differently next time?
I am proud that I was able to complete this in general. I felt like I am a world beyond what my last project was. Next time I would like to rely less on resources and focus more on completing it myself.
What challenges did you encounter, and how did you overcome them?
My biggest challenge this time around was making the website responsive to smaller devices. After a little digging I found using min-height and max-width makes all the difference and saves me from having to use multiple media queries.
What specific areas of your project would you like help with?
Just an over view of what I did right and what I still need to work and is all the help I could ask for.
Sadik Rahman• 190@Coder-Sadik
Posted
Your code uses semantic HTML effectively, but replacing some
<div>tags with more meaningful elements like<article>could enhance it further. Accessibility is generally good, though addingaria-labelswould make it stronger. The layout is responsive, but testing on a wider range of screen sizes and using relative units would improve scalability. The code is well-structured and readable, but grouping related styles and using CSS variables could enhance reusability. Design alignment is mostly accurate, but comparing with the mockup for exact matching is recommended. Overall, your solution is solid with room for small adjustments in accessibility, responsiveness, and reusability.Marked as helpful
1 - Soniawan• 100
@soniawan
Submitted
Sadik Rahman• 190@Coder-Sadik
Posted
You can use semantic html tags which will be more convenient for the screen reader software. Design and solution looks exactly same, well measurement, just the color of
<p>tag is a bit different.Marked as helpful
0
