@TedJenkler
Posted
Hi @dearestalexander,
Nice project! I love how you’ve added your own touch—always fun to see creative ideas come to life. I’m heading to Bangkok next month myself, so can’t wait for some vacation time!
Great job on the detailed README. It’s often overlooked but so useful for future reference. A small suggestion: organize images in an assets folder to tidy up your GitHub structure.
You’ve received lots of feedback already, so I’ll sum it up with the most important ones to help take your projects to the next level:
1.Centering: "Use flex properties and min-height: 100svh to center your component." Avoid fixed width; use max-width in rem.
2.Naming conventions: Try BEM for more scalable CSS.
3.ID selectors: "Stick with class="" for styling, as #ID is best for JavaScript."
4.Responsive design: "Use max-width: 100% for responsiveness over width: 100%."
5.Font-size: "Avoid px; use rem or em for responsive typography."
(Not ordered by importance just for readability)
Keep up the great work!
Best, Teodor
(@Stroudy and @grace-snow gave really good feedback. Try making a list, cross it off as you go, and you’ll implement all the tips in no time.
@Coder-Sadik’s feedback is good, but in this project, I’d say once you purge unnecessary divs and add semantic elements, there’s no real need for ARIA labels (Made that mistake myself before.
Thanks again for catching that “lacking” learned alot by that mistake, @geomydas!).
Marked as helpful
@dearestalexander
Posted
Hi @TedJenkler
Thanks for the feedback. Yes - I was delighted to see all the detailed feedback from Grace, Steven and now you.
I keep quite detailed notes from my learning on HTML / CSS and javascript that I keep in markdown, I did publish the first versions after completing the freeCodeCamp courses, so you can see how OCD I am with notes lol:
my HTML/CSS notes my JavaScript notes
Since completing those courses I already updated my notes a lot, for example whole new section on variable fonts thanks to frontendmentor :)
I'm now looking forward to adding a new section on good practices and also updating various existing sections with all the feedbacks received.
(by the way my website above is still a first draft I created while I am learning, - please don't look at the HTML or CSS, it needs revision lol)
I just came back to Bangkok a few days ago. I was considering moving back to London, but after a month there apartment hunting I just couldn't find a 1 bed flat that wasn't depressing for under £2000 pcm! So happy to be back here in Thailand, people seem happier, food is better, apartments are better, and plenty of cultural activities to enjoy.
@TedJenkler
Posted
@dearestalexander
I totally feel you! I’ve got an apartment in BKK for only about 100 euros a month, which is way better than the 500 I'm paying here (though it’s still decent compared to Greece). I've been thinking about quitting my job and diving into freelancing on Upwork, with my girlfriend's job as a bit of a backup plan but can be risky in this economy. But man, I’d absolutely kill for some 1.5 euro street food right now, haha!
Marked as helpful
@dearestalexander
Posted
Hi @TedJenkler
I worked through these, and I think it's much improved thanks, here were the details so far. It'll take some time for me to decide on the right reset, so that's going to be in progress through the next challenges.
Centering: "Use flex properties and min-height: 100svh to center your component." Avoid fixed width; use max-width in rem.
-
Update made: Thanks, updated Naming conventions: Try BEM for more scalable CSS.
-
Update made: Read up on this, it’s great. Have had a go at implementing it. ID selectors: "Stick with class="" for styling, as #ID is best for JavaScript."
-
Update made: Thanks, updated. This helped resolve some precedence complexities too.
Responsive design: "Use max-width: 100% for responsiveness over width: 100%."
- Update made: Thanks, updated. I’m starting to understand the idea now with responsive designs
Font-size: "Avoid px; use rem or em for responsive typography."
- Update made: Thanks, updated