@ebubz-devSubmitted 7 months ago
Latest comments
- @Coder-SadikPosted 7 months ago
Mobile and desktop screens look good, but you should also make the design responsive for tablet screens.
0 - @ebubz-devSubmitted 7 months ago@Coder-SadikPosted 7 months ago
Great solution. I have also learned a new way using grid from your code. Only the thing I can say, the horizontal gaps between columns in big screen can be changed.
Marked as helpful0 - @mdnaimurSubmitted 7 months ago
- @Dmino228Submitted 8 months ago@Coder-SadikPosted 7 months ago
This HTML and CSS code is well-structured, clean, and adheres to best practices. The use of custom CSS variables for color management is efficient, and the typography choices complement the recipe page's aesthetic. The layout is responsive, with media queries ensuring good display on smaller screens. The semantic use of HTML elements like <main>, <h1>, and <p> enhances accessibility.
0 - @jeimosSubmitted 7 months ago@Coder-SadikPosted 7 months ago
Your code is well-organized and responsive, with a clear structure for both desktop and mobile views. The use of CSS for consistent styling is effective, but consider using relative units (like
emor%) for the body width to enhance flexibility. The hover effects are well-implemented, adding a nice interactive touch. You could improve accessibility by adding alt text for the buttons and ensuring color contrast meets accessibility standards. Overall, it’s a solid implementation with minor adjustments needed for scalability and accessibility.0 - P@dearestalexanderSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I decided to try and go a bit further than the template and add a second verison with colour and content adjustments. I used JavaScript to do this. I found this experience useful as I learnt a little bit about inheritence and precedence when trying to switch styles between CSS items with id selectors using classes. I also hadn't realised getElementByClassName returned a live collection vs. documentQuerySelectorAll returning a static nodelist.
What challenges did you encounter, and how did you overcome them?Just getting used to precedence.
Was initially a bit unsure on whether to use alternate classes in CSS for styling changes or whether to hard code the alternate styles values in JavaScript. I decided on the former approach as I think it's easier to manage future style adjustments if all style factors are in CSS. I think the content changes have to be hardcoded into JavaScript, at least without having a database?
What specific areas of your project would you like help with?Wondering if my JavaScript approach is relatively efficient or if there are better ways to do this?
@Coder-SadikPosted 7 months agoAdding alternative design is really appreciated. Your code handles the style toggle effectively, updating elements like name, location, bio, and social links. The use of CSS variables for colors and font sizes ensures consistency and maintainability. The design is responsive, with a media query to handle smaller screens.
Marked as helpful0
