Md Abid Hussain• 400
@md-abid-hussain
Submitted
Che Fernandez
@CheFernandez99
All comments
- Che Fernandez• 190
@CheFernandez99
Posted
may i ask how you got that button to stay on the container as the container moves, im assuming you made the position absolute. I had an issue where the advice moving also moved the container and my button wouldn't stick to the container and move with it lik yours is
1 - Sameh• 430
@SamehCode
Submitted
Che Fernandez• 190@CheFernandez99
Posted
hi I copied your code from git hub, i will edited the issues and send the edits back to you! if you like it you can merge it with your original code, if not then you don't have to. let me know what you think?
1 - Sameh• 430
@SamehCode
Submitted
Che Fernandez• 190@CheFernandez99
Posted
great effort just a few things. you should change the background colour of the right box in mobile you should make the width the same as the box width, make the colours solid not transparent. for mobile optimization it helps to open the port on your mobile phone.
Marked as helpful
0 - berealisss• 10
@berealisss
Submitted
In the process I found it tedious placing child elements within the parent element (i.e. spacing "qr-container" and "text-containers").
What are the best practices of spacing elements?
Che Fernandez• 190@CheFernandez99
Posted
all of your content should be in the child container, no containers are necessary inside the child just work out a good margin and padding ratio to space it out, I recommend using rem not % or px when dealing with spacing. you almost had it. the parent is merely for centering purposes.
Marked as helpful
1 @wahidullahsharify
Submitted
Che Fernandez• 190@CheFernandez99
Posted
your design looks great, however it is clippping at the top of the page on mobile devices, id recommend adding a margin to the top. Great work!!
0- Chriscent Pingol• 230
@KishonShrill
Submitted
Che Fernandez• 190@CheFernandez99
Posted
one question, why use var instead of const since this is es6?
1 - natancent• 70
@natancent
Submitted
Making the desktop version was quite easy ,i'm just not sure about the mobile version ,still got a lot to learn.
Che Fernandez• 190@CheFernandez99
Posted
I believe you put your divs in a section or another div cause it fits my mobile screen however its nit responsive to my mobile it just shows the desktop design buy on mobile. The mobile version is easy with a media query just look into media queries
Marked as helpful
0 - Mohamed Mostafa• 480
@Mohamedkazafy
Submitted
Che Fernandez• 190@CheFernandez99
Posted
Not bad, work on trying to centre the div and adding margin to keep your icons inline Also try making the icon size the same. The background image seems like it's not there at all, it would help to had background img src and position it to top But overall good effort
Marked as helpful
1 - Pierre Castro• 40
@pierre-castro
Submitted
Che Fernandez• 190@CheFernandez99
Posted
Hey looks not too bad, idk if you used javascript and css I can't find those files on github. But I viewd your site on my mobile and it needs a media query in css the app doesn't fit my mobile screen media queries with small screen size can fix this issue. You're icons are functional. I just could find your code to see what you were doing. But overall good
0 - Che Fernandez• 190
@CheFernandez99
Submitted
i found it quite difficult to properly round off the borders of each component in results. the media query was a pain. also could not overlap the right box onto the left i tried using the shadowing to create that illusion. lastley idk if its cause this is a newb project but the media query only works on mobile its not optimised to tablets and ipads...which i intend to run into in future.
Che Fernandez• 190@CheFernandez99
Posted
i noticed after i uploaded the project that the button went outside the box this is likely due to margins.
0
