Skip to content
OverviewSolutions
23
Comments
21

Shane Chaffe

@ChaffexdLondon, UK900 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    Hey!

    Really good attempt at the project, it's very clean. Good use of Tailwind here to style it as well.

    It's a well made out project, the only thing I have feedback on is the shopping cart. When you have a total it's just a number, you don't have a $ for the total amount in the shopping cart as one normally would!

    Considering adding this to ensure the user knows this is the total to provide a good user experience!

    Other than that, well done!

    Marked as helpful
    3
  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    This is a really good attempt at the project!

    I like the layout and clean transition between themes. I think the only suggestion I have is to make the theme settings have a hover effect, by that I mean cursor: pointer; so the user knows the interact with it.

    Other than that I think this is a well-executed project!

    Marked as helpful
    0
  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    This is a well though out attempt at the project!

    One piece of feedback I have is when you rotate through the quotes, the container size changes. Have you thought about maintaining a single container size so it doesn't change?

    Also, it might be a cool idea to consider using Axios to perform your GET request to learn more technologies!

    Nice job!

    Marked as helpful
    0
  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    Hey Momin,

    To answer your question about using grid in flex or vice-versa, yes you absolutely can. They work extremely well with each other actually!

    I strongly recommend you taking a look at https://developer.mozilla.org/en-US/docs/Web/CSS/Pseudo-classes so you can help bring your projects to life.

    Good job!

    Marked as helpful
    1
  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    Hey Kamil,

    Firstly, well done on delivering your first JS focussed project!

    Great start! Dealing with forms is a tough topic when it comes to JS, at least I think so.

    I have some pointers you might want to improve on:

    • NaN when the form is blank isn't a good user experience, you should validate there is input before submission like the design suggests, you should throw an error when the input is blank
    • I was also able to submit the form when I accidently put a typo in and got the result: -17950 years 3 months 26 days My input was: 10 / 012/ 19972 which is of course incorrect.

    This is what makes this task so difficult because there are so many areas to cover! Other than that, well done!

    Marked as helpful
    1
  • Shane Chaffe•900
    @ChaffexdPosted about 2 years ago

    This is a really good implementation of the design! You copied it pretty much 1 for 1. Well done!

    • One thing that initially confused me was that the nav bar menu items can't be dropped if you click the arrow, as a user that is what I am used to so it made sense for me to click there but it didn't work. Have you considered including that img as part of your p? Or maybe wrapping it all in a button <button><img /></button> for example so you have both pieces of markup available for the drop down?

    Other than that, no feedback!

    Marked as helpful
    0
View more comments