Age Calculator App

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main element instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Shane Chaffe•900

  @ChaffexdPosted over 1 year ago

  Hey Kamil,

  Firstly, well done on delivering your first JS focussed project!

  Great start! Dealing with forms is a tough topic when it comes to JS, at least I think so.

  I have some pointers you might want to improve on:

  • NaN when the form is blank isn't a good user experience, you should validate there is input before submission like the design suggests, you should throw an error when the input is blank
  • I was also able to submit the form when I accidently put a typo in and got the result: -17950 years 3 months 26 days My input was: 10 / 012/ 19972 which is of course incorrect.

  This is what makes this task so difficult because there are so many areas to cover! Other than that, well done!

  Marked as helpful

  1