@devanshraghav
Submitted
Looking to hire developers?
@CarltonMpofu
@devanshraghav
Submitted
@CarltonMpofu
Posted
Hey, hey, congratulations on completing the challenge :)
Here are some pointers to note:
Hope that helps :)
Marked as helpful
@henriquelmk
Submitted
First challenge here. I'd be happy to hear any feedback!
@CarltonMpofu
Posted
Awesome work!
Looks good.
Congrats on completing your first challenge.
Keep going :)
I don't have any formal training on what "good code" is supposed to look like, so my worry is that my code looks a 3 year old's grammar sounds. Ha.
If anyone has suggestions on "best practices" when it comes to code layout, that would be helpful. Should I group my CSS differently? Is there a better way to make my code readable? Any resources to read or watch would be welcomed as well.
Thanks!
@CarltonMpofu
Posted
Hi.
It seems like the browser does not show the whole background image. Use background-size:contain in the body to make it show the whole image. However, the browser will not show the whole image when you zoom out. Refer to https://stackoverflow.com/questions/17555682/height-100-or-min-height-100-for-html-and-body-elements on how to apply a background image that fills the entire browser.
Setting the width of the summary-container to 450px does will not make it responsive. The width will always be 450px, even on a device with a smaller size. The summary-container will be too large, especially on mobile devices. Instead use max-width:450px to make it more responsive.
Also, add the property max-width:100% to the illustration image to make it fill the container regardless of the size.
Marked as helpful