@Bashamega
@christiano84
Submitted
This was done in vanilla HTML, CSS and Javascript. If I had to do it all over again I would do it in a framework like React and use something like Tailwind to speed up the whole process.
I could use advice on the mobile menu. I feel like there is a better way to accomplish it programatically in JS or React.
@Bashamega
Posted
Hello:) It is very good, and your code is clear and readably. The only thing I noticed was that you included the design folder and the README-template.md and the style guide and website-text but you should exclude this in your GitHub repo. Also try setting the active tab to be black but thee unactive tabs to grey
@GermanGuerrero95
Submitted
Greetings. This is my Newsletter Sign-Up Form with Success Message project. All suggestions are welcome. I'm still in the learning process. Thank you very much.
@Bashamega
Posted
Hello:) It looks awesome. I have noticed 2 issues. First it is not very responsive on large screens, like it looks good on my laptop but horrible on my monitor. Also, you should add a hover effect for the button. and the confirmation the email should be the email that the user has entered, and you can achieve this with some js. However, the overall is great. I how you had a great time completing this challenge.
@hanzala-bhutto
Submitted
@Bashamega
Posted
It is great, and awesome. I suggest that you try to use semantic html instead of divs like nav, main, and footer tags. Also I think the crew page should be a slideshow and the crew members images get a little bigger
@LucianEmanuel
Submitted
Aany feedback is welcome
@Bashamega
Posted
It is awesome, but I suggest make the images more bright by default
@Twixii99
Submitted
After reading my code, what can I do better to make my code more readable and bug-free? ( I followed "Kevin Powell" thought process in thinking about breaking out the challenge to more easy parts and write more cleaner code )
How to gain more information and learn more about FE-development?
@Bashamega
Posted
Hello:) It is very good and responsive. I suggest removing the default front end mentor style and also try using semantic HTML, for example use the footer tag instead of the div tag.
@MrDevM
Submitted
am unsure of responsiveness at width of 700-800px
@Bashamega
Posted
Hello Mulugeta I have checked it in my browser the responsive view, it is fine, but the image is stretchy. I suggest not specifying the height of the image or setting it to auto and this should resolve the issue
Marked as helpful
@yret1
Submitted
My first larger project!
Figured out using JSON to make life a bit easier.
Feedback is appriciated!
@Bashamega
Posted
Hello:) Your project looks great in the screenshot, but for some reason the buttons are on the Wikipedia link, and the details are not visible.
Also, you should set the cursor to be a pointer for the buttons.
Marked as helpful
@SalmaHazzem
Submitted
@Bashamega
Posted
Hello salma:) I have looked at your project, but I think that there should be some changes. I have noticed that the font is not the same as the font that frontend mento instructed and also I have noticed that the divider is not visible and also that the button icon is not the same. The starter code has the divider and the button images, so you don't have to create the image. Please read the instructions again and use the images from the starter code. But keep it up!
@ICUBE321
Submitted
Any feedback would be much appreciated :)
@Bashamega
Posted
Hello:)
It looks great. I just noticed that the red dot on the unread messages is not showing, second I think it would be better if you can add some functionality to make the mark as read button working.
Other than that, keep it up!
@vgarmy
Submitted
What are you most proud of, and what would you do differently next time?
I like the mobil solution, and use of less code.
What challenges did you encounter, and how did you overcome them?
Hade som problems with the image.
What specific areas of your project would you like help with?
None
@Bashamega
Posted
Hello:) I think you can use flex in this challenge because it is only 2 rows. But it is always great to practice the grid. If you want to learn more about the difference you can checkout this link
Marked as helpful
@Djonali
Submitted
Hi, Please review my solution and provide your feedback.
@Bashamega
Posted
Hello Djonali:)
I have tested your project multiple of times. I have noticed only three issues.
<input type="text" id="days" class="form-container-input" placeholder="DD" oninput="onInputChange(days.value, event)" type="number">
Marked as helpful
