Skip to content
OverviewSolutions
12
Comments
3
Ozan Zorlu
@zorluozan

All comments

  • Ozan Zorlu•280
    @zorluozanPosted over 2 years ago

    Hi Annas,

    Nice work. I look at your code and here are some suggestions if you want to improve your project;

    1- About the responsiveness, I think you misunderstand some points. In responsive design, there are two approaches which is mobile-first and desktop-first. In mobile-first approach, you write your code according to the mobile design and use min-width for the media queries to get desktop version. You should make some research about responsive design.

    2- You should check active states of the project. You didn't implement any active state such as when hover them icons and items in footer.

    3- If you look at the design, you should check learn more links. The positions under the learn more links is closer.

    4- You must use alt attributes to all images. I guess you forgot to put some of the alt attributes but that is okey. You can fix that easily.

    5- You should check for the mobile menu position from the design.

    6- Try to use semantic html elements for accessibility such as main,header,footer,section etc.

    That's all I wanted to say about. Happy coding :)

    Marked as helpful
    1
  • Ozan Zorlu•280
    @zorluozanPosted over 2 years ago

    Hi Hasan, Nice work. Here are some suggestions if you want to improve your project;

    1- I think you should check dl element usage. Instead of using dl element, you can use div element for each item. Check this link for dl https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element

    2- I think you have some problem about responsiveness. You should fix responsibility because when I shrink the screen, most of the things are overflowing.

    3- Your cube in desktop version is not fixed onto the image. If you check the design, you should fix that and whenever you shrink or grow the page, it shouldn't be go away. You can use absolute positioning for this.

    4- It is good to use jquery but when you use them, you should create a js file and write the code inside that. With this way, your code will be reusable. But if you want to do inside html file, then do this before the closing of the body. And you don't have to use type attribute when defining script tag.

    That's all I wanted to say. Keep coding :)

    Marked as helpful
    0
  • Ozan Zorlu•280
    @zorluozanPosted over 2 years ago

    Hi Sammy,

    Nice work. Here are some suggestions if you want to improve your project;

    1- You shouldn't use div element inside ul element. Instead, you can just give li element and to reach that element, you can use last-child selector. If you want to read about last-child check this out: https://developer.mozilla.org/en-US/docs/Web/CSS/:last-child?retiredLocale=en

    2- ID's in CSS are unique and you should be careful about naming them. I don't prefer to use IDs unless I write any js code.

    3- You missed some hover effects such as icons in footer. Also, if you check the design, you'll see that learn more has underlining effect in it. You should check active states :)

    That's all I wanted to say about. Keep coding :)

    Marked as helpful
    0